Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [extensions] support old APIs with enable_electron_extensions #21812

Merged
merged 1 commit into from Jan 21, 2020
Merged

chore: [extensions] support old APIs with enable_electron_extensions #21812

merged 1 commit into from Jan 21, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 17, 2020 •
edited

Description of Change

This allows for a deprecation phase-out of the old BrowserWindow.*Extension APIs when we cut over to the new extensions implementation.

See #21809 for the docs.

Ref #19447

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 17, 2020
This was referenced Jan 17, 2020
Merged
Closed
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 18, 2020
@nornagon nornagon merged commit acb5b75 into master Jan 21, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 21, 2020

No Release Notes

@nornagon nornagon deleted the extensions-shim branch January 21, 2020 17:43
@miniak miniak mentioned this pull request Nov 27, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz