Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable native extensions support #21814

Merged
merged 19 commits into from Feb 3, 2020
Merged

feat: enable native extensions support #21814

merged 19 commits into from Feb 3, 2020

Conversation

nornagon
Copy link
Member

Description of Change

This enables the enable_electron_extensions flag by default.

Ref #19447

Checklist

Release Notes

Notes: Switched to a native-backed implementation of Chrome Extensions.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 17, 2020
@nornagon
Copy link
Member Author

This is marked [WIP] because there are several outstanding PRs that I'd like to merge before this one: #21812, #21811, #21809, and #21804. But I do believe this feature is ready to be switched on!

@nornagon nornagon mentioned this pull request Jan 17, 2020
Closed
11 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 18, 2020
@nornagon nornagon mentioned this pull request Jan 21, 2020
Closed
3 tasks
@nornagon nornagon removed the wip ⚒ label Jan 21, 2020
@nornagon nornagon mentioned this pull request Jan 29, 2020
Merged
6 tasks
zcbenz
zcbenz approved these changes Jan 30, 2020
View reviewed changes
shell/browser/api/atom_api_session.cc Outdated
if (extension) {
if (!error_msg.empty()) {
LOG(INFO) << "ELW 1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, good catch!

@nornagon
Copy link
Member Author

nornagon commented Feb 3, 2020

CI failures are unrelated to this PR; merging.

@nornagon nornagon merged commit a061c87 into master Feb 3, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 3, 2020

Release Notes Persisted

Switched to a native-backed implementation of Chrome Extensions.

@nornagon nornagon deleted the enable-electron-extensions branch February 4, 2020 00:59
@nornagon nornagon mentioned this pull request Feb 10, 2020
Closed
@erickzhao erickzhao mentioned this pull request May 7, 2020
Merged
@nornagon nornagon mentioned this pull request May 20, 2020
Closed
3 tasks
@rafeca rafeca mentioned this pull request Jul 17, 2020
Merged
@erickzhao erickzhao mentioned this pull request Nov 3, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz