Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [extensions] load extensions on the IO thread #21811

Merged
merged 2 commits into from Jan 21, 2020
Merged

fix: [extensions] load extensions on the IO thread #21811

merged 2 commits into from Jan 21, 2020

Conversation

nornagon
Copy link
Member

Description of Change

The sync loading on the UI thread was temporary.

Ref #19447

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 17, 2020
@nornagon nornagon mentioned this pull request Jan 17, 2020
Merged
6 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 18, 2020
@nornagon nornagon merged commit 100a85f into master Jan 21, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 21, 2020

No Release Notes

@nornagon nornagon deleted the extensions-async-load branch January 21, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz