Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly free remote objects (6-1-x) #20694

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix: properly free remote objects (6-1-x) #20694

merged 1 commit into from
Oct 23, 2019

Conversation

nornagon
Copy link
Member

Backport of #20671. See that change for details.

Notes: Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2019
@trop trop bot mentioned this pull request Oct 23, 2019
Merged
5 tasks
@trop trop bot added 6-1-x backport This is a backport PR labels Oct 23, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2019
@nornagon nornagon merged commit e3a79d6 into 6-1-x Oct 23, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 23, 2019

Release Notes Persisted

Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@nornagon nornagon deleted the backport/6-1-x/fix-remote-object-freer branch October 23, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
6-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @jkleinsc