Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly free remote objects #20671

Merged
merged 2 commits into from Oct 22, 2019
Merged

fix: properly free remote objects #20671

merged 2 commits into from Oct 22, 2019

Conversation

nornagon
Copy link
Member

Description of Change

This was introduced when switching to mojo; at one point when the mojo change was still in progress the browser interface was an associated interface, but it no longer is, so this was failing silently (!).

Checklist

Release Notes

Notes: Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@nornagon nornagon requested a review from miniak October 21, 2019 22:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 22, 2019
@nornagon nornagon merged commit cde2aae into master Oct 22, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 22, 2019

Release Notes Persisted

Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@trop
Copy link
Contributor

trop bot commented Oct 22, 2019

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-1-x label Oct 22, 2019
@trop
Copy link
Contributor

trop bot commented Oct 22, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

@trop
Copy link
Contributor

trop bot commented Oct 22, 2019

@nornagon has manually backported this PR to "7-0-x", please check out #20693

@trop
Copy link
Contributor

trop bot commented Oct 23, 2019

@nornagon has manually backported this PR to "6-1-x", please check out #20694

@miniak miniak deleted the fix-remote-object-freer branch October 23, 2019 07:47
@trop trop bot removed the in-flight/7-0-x label Oct 23, 2019
@sofianguy sofianguy added this to Fixed in 6.1.1 in 6.1.x Oct 24, 2019
@sofianguy sofianguy added this to Fixed in 7.0.1 in 7.2.x Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
Fixed in 6.1.1
7.2.x
Fixed in 7.0.1
Development

Successfully merging this pull request may close these issues.

None yet

3 participants