Update @typescript-eslint to ensure compatibility with TypeScript v3.9 #74091

mshustov · 2020-08-03T14:59:46Z

Summary

Eslint stopped working at #73924 so I had to start working on the fix.
This PR update @typescript-eslint version to make it compatible with TypeScript v3.9. Unfortunately, we still have to update @typescript-eslint to v4 (still in alpha) to ensure full compatibility with TypeScript v4, I'd rather make it in a separate PR.

@typescript-eslint 3.0 release notes: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0
This PR:

updates @typescript-eslint
removes outdated rules @typescript-eslint/camelcase @typescript-eslint/class-name-casing in favour of @typescript-eslint/naming-convention
fixes and mutes newly introduced naming style errors
adds eslint-comments plugin to detect unused eslint-disable, eslint-enable instructions
removes unused eslint-disable, eslint-enable instructions. most of them were added before plugins started rewriting eslint rules on per plugin basis
adds no-script-url and no-unsanitized/property rules for typescript files to fix no unused eslint-disable rule

Known problems

@typescript-eslint/naming-convention doesn't support multiple underscores as a valid prefix/suffix. I filtered out such problem places until the problem is fixed in [naming-convention] Allow multiple underscore typescript-eslint/typescript-eslint#1712
@typescript-eslint/naming-convention stated reporting CSS classes name format (for example, componentName__element--modifier, componentName__element__element) For now I muted such errors. We might need to create a naming convention to filter them out.
We have tons of rules declared for *.js files only and it's time we aligned them with *.ts files linting rules in a followup @elastic/kibana-operations I can create an issue, who is the right owner for it?
eslint task time on CI increased from 29m to 33m.

For maintainers

This was checked for breaking API changes and was labeled appropriately

joshdover

Platform changes LGTM

adds eslint-comments plugin to detect unused eslint-disable, eslint-enable instructions

💯 love it

alisonelizabeth

ES UI changes LGTM

legrego

Security changes LGTM

walterra

ML/Transform changes LGTM.

timroes

Reviewed code change of Kibana App only, LGTM

kertal

Code LGTM, KibanaApp code owner review, since there were just comments added and removed didn't test

x-pack/plugins/apm/server/saved_objects/apm_indices.ts

x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts

dgieselaar

LGTM, left suggestions for one or two possible improvements.

shahzad31

LGTM , uptime changes !!

mikecote

Alerting code LGTM

poffdeluxe

Canvas changes look good to me

kibanamachine · 2020-08-05T15:21:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 903f0e6

Build metrics

async chunks size

id	value	diff	baseline
crossClusterReplication	462.5KB	-10.0B	462.5KB
indexManagement	1.5MB	-2.0B	1.5MB
ingestPipelines	579.2KB	+10.0B	579.2KB
maps	3.3MB	-3.0B	3.3MB
securitySolution	7.3MB	+8.0B	7.3MB
total	-	+3.0B	-

page load bundle size

id	value	diff	baseline
data	1.4MB	-2.0B	1.4MB
upgradeAssistant	65.3KB	+39.0B	65.2KB
total	-	+37.0B	-

History

💔 Build #66626 failed cb6ef65
💚 Build #66571 succeeded 0005b9f
💚 Build #66554 succeeded 8624390
💔 Build #66372 failed a485064
💔 Build #66342 failed 3cd56cd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#74091) * bump @typescript-eslint deps * update rules * fix errors in pacakges * fix src/ * fix x-pack * fix test * fix typings * fix examples * allow _ as prefix and suffix * roll back prefix and suffix changes * add eslint-plugin-eslint-comments * report unused rules * remove unused eslint comments from tests * remove unused eslint comments 2nd pass * remove unused eslint comments from src/ * remove unused comments in x-pack * use no-script-url and no-unsanitized/property for ts files * remove unused eslint comments * eui/href-or-on-click removed when not complained * no import/* rules for ts files * cleanup * remove the unused eslint-disable * rollback unnecessary changes * allow underscore prefix & sufix in type name * update docs * fix type error in enterprise search plugin mocks * rename platform hack __coreProvider --> _coreProvider * rollback space removal in src/core/public/legacy/legacy_service.test.ts * fix naming convention in APM # Conflicts: # src/legacy/ui/public/new_platform/new_platform.ts # x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx

…pt v3.9 (#74091) (#74384) * Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) * bump @typescript-eslint deps * update rules * fix errors in pacakges * fix src/ * fix x-pack * fix test * fix typings * fix examples * allow _ as prefix and suffix * roll back prefix and suffix changes * add eslint-plugin-eslint-comments * report unused rules * remove unused eslint comments from tests * remove unused eslint comments 2nd pass * remove unused eslint comments from src/ * remove unused comments in x-pack * use no-script-url and no-unsanitized/property for ts files * remove unused eslint comments * eui/href-or-on-click removed when not complained * no import/* rules for ts files * cleanup * remove the unused eslint-disable * rollback unnecessary changes * allow underscore prefix & sufix in type name * update docs * fix type error in enterprise search plugin mocks * rename platform hack __coreProvider --> _coreProvider * rollback space removal in src/core/public/legacy/legacy_service.test.ts * fix naming convention in APM # Conflicts: # src/legacy/ui/public/new_platform/new_platform.ts # x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx * remove unnecessary comment

mshustov added 7 commits August 3, 2020 16:54

bump @typescript-eslint deps

fbe03ca

update rules

cc9bf33

fix errors in pacakges

4b4caee

fix src/

501d03a

fix x-pack

1bcf024

fix test

d57e26f

fix typings

1a68b99

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 3, 2020

mshustov added this to Pending Review in kibana-core [DEPRECATED] via automation Aug 3, 2020

mshustov added this to In Progress in Kibana developer experience [NOTICE TO CLOSE] Aug 3, 2020

mshustov added 17 commits August 3, 2020 21:29

fix examples

b82c4dc

Merge branch 'master' into update-ts-lint

b5cb2ed

allow _ as prefix and suffix

9aca3a9

roll back prefix and suffix changes

07c8d47

add eslint-plugin-eslint-comments

aae845f

report unused rules

36c3acb

remove unused eslint comments from tests

ad716ba

remove unused eslint comments 2nd pass

d00b9cc

remove unused eslint comments from src/

b003a0d

remove unused comments in x-pack

de28deb

use no-script-url and no-unsanitized/property for ts files

536db02

remove unused eslint comments

968f43c

eui/href-or-on-click removed when not complained

1c3e9b0

no import/* rules for ts files

da9470c

cleanup

c2b8195

remove the unused eslint-disable

c496f3b

Merge branch 'master' into update-ts-lint

ceebb83

joshdover approved these changes Aug 4, 2020

View reviewed changes

alisonelizabeth approved these changes Aug 5, 2020

View reviewed changes

legrego approved these changes Aug 5, 2020

View reviewed changes

mshustov added 2 commits August 5, 2020 08:32

Merge branch 'master' into update-ts-lint

83e9017

rollback space removal in src/core/public/legacy/legacy_service.test.ts

8624390

walterra approved these changes Aug 5, 2020

View reviewed changes

timroes approved these changes Aug 5, 2020

View reviewed changes

kertal approved these changes Aug 5, 2020

View reviewed changes

streamich approved these changes Aug 5, 2020

View reviewed changes

dgieselaar reviewed Aug 5, 2020

View reviewed changes

x-pack/plugins/apm/server/saved_objects/apm_indices.ts Show resolved Hide resolved

dgieselaar reviewed Aug 5, 2020

View reviewed changes

x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts Outdated Show resolved Hide resolved

dgieselaar approved these changes Aug 5, 2020

View reviewed changes

mshustov added 2 commits August 5, 2020 10:33

fix naming convention in APM

9c6ebb0

Merge branch 'master' into update-ts-lint

0005b9f

patrykkopycinski approved these changes Aug 5, 2020

View reviewed changes

shahzad31 approved these changes Aug 5, 2020

View reviewed changes

mikecote approved these changes Aug 5, 2020

View reviewed changes

mshustov added 2 commits August 5, 2020 14:45

Merge branch 'master' into update-ts-lint

cb6ef65

Merge branch 'master' into update-ts-lint

903f0e6

poffdeluxe approved these changes Aug 5, 2020

View reviewed changes

mshustov merged commit 88c0631 into elastic:master Aug 5, 2020

kibana-core [DEPRECATED] automation moved this from Pending Review to Done (7.10) Aug 5, 2020

mshustov deleted the update-ts-lint branch August 5, 2020 15:32

mshustov moved this from In Progress to Done in Kibana developer experience [NOTICE TO CLOSE] Aug 5, 2020

mshustov mentioned this pull request Aug 5, 2020

[7.x] Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) #74384

Merged

mshustov mentioned this pull request Aug 5, 2020

Add a convention for CSS class names generated within js files #74390

Open

mshustov added the backported label Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update @typescript-eslint to ensure compatibility with TypeScript v3.9 #74091

Update @typescript-eslint to ensure compatibility with TypeScript v3.9 #74091

mshustov commented Aug 3, 2020 •

edited

joshdover left a comment

alisonelizabeth left a comment

legrego left a comment

walterra left a comment

timroes left a comment

kertal left a comment

dgieselaar left a comment

shahzad31 left a comment

mikecote left a comment

poffdeluxe left a comment

kibanamachine commented Aug 5, 2020

Update @typescript-eslint to ensure compatibility with TypeScript v3.9 #74091

Update @typescript-eslint to ensure compatibility with TypeScript v3.9 #74091

Conversation

mshustov commented Aug 3, 2020 • edited

Summary

Known problems

For maintainers

joshdover left a comment

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

legrego left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

dgieselaar left a comment

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

poffdeluxe left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 5, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

mshustov commented Aug 3, 2020 •

edited