Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) #74384

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Aug 5, 2020

Backports the following commits to 7.x:

elastic#74091)

* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
# Conflicts:
#	src/legacy/ui/public/new_platform/new_platform.ts
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
crossClusterReplication 462.5KB -10.0B 462.5KB
indexManagement 1.1MB -2.0B 1.1MB
ingestPipelines 584.9KB +10.0B 584.9KB
maps 3.3MB -3.0B 3.3MB
securitySolution 7.3MB +8.0B 7.3MB
total +3.0B

page load bundle size

id value diff baseline
data 1.4MB -2.0B 1.4MB
upgradeAssistant 64.8KB +39.0B 64.8KB
total +37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit b2040a5 into elastic:7.x Aug 5, 2020
@mshustov mshustov deleted the backport/7.x/pr-74091 branch August 5, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants