Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] upgrade to mocha 5.2.0 #19264

Closed
wants to merge 1 commit into from
Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 21, 2018

Now that mocha has patched and released mochajs/mocha#3346 we can upgrade to 5.2.0 which was the reason we had to downgrade mocha in #19238.

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.4.0 labels May 21, 2018
@spalger spalger requested a review from azasypkin May 21, 2018 16:27
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger requested a review from epixa May 21, 2018 17:49
@epixa epixa mentioned this pull request May 21, 2018
@epixa
Copy link
Contributor

epixa commented May 21, 2018

I created some test failures throughout the codebase to run with this change, and they were handled properly for intake and selenium. In the x-pack job, they did error, but the error message was swallowed and another useless message was shown instead.

My commit was afe91b1

Here's the selenium job that failed with that change on top of this PR: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-x-pack/1359/console

Here's the same tests run against master (to be specific, with this mocha bump reverted): https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-x-pack/1365/console

As you can see, the tests failures without your change resulted in a nice and clear error message and stack trace at the bottom of the test output, as you'd expect: Error: expected true to equal false

However, when run with these changes, there is no clear error message and the error that appears seems to be something else entirely: test.titlePath is not a function

If you're interested, this is all going down in this temporary PR: #19268

@spalger
Copy link
Contributor Author

spalger commented May 21, 2018

Wow, @epixa want to just write tests for Mocha? :P

I'm not interested in fixing mocha, lets just stick with what we know works... Too bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants