Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERTED] Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 #22816

Merged
merged 7 commits into from Oct 22, 2018
Merged

[REVERTED] Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 #22816

merged 7 commits into from Oct 22, 2018
+131 −314

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Sep 7, 2018 •
edited

No description provided.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal added the Team:Operations Team label for Operations Team label Sep 7, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

mistic
mistic approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after solving some conflicts)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb merged commit 1b2e7f4 into elastic:master Oct 22, 2018
@kobelb kobelb deleted the upgrade/mocha branch October 22, 2018 14:37
@kobelb kobelb mentioned this pull request Oct 22, 2018
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Oct 22, 2018
@kobelb
Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 (elastic#22816)
9536491 
* Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0

* Fixing x-pack yarn.lock

* Switching x-pack to ^5.2.0

* Fixing yarn.lock
ryankeairns pushed a commit that referenced this pull request Oct 22, 2018
@kobelb @ryankeairns
Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 (#22816)
42b046f 
* Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0

* Fixing x-pack yarn.lock

* Switching x-pack to ^5.2.0

* Fixing yarn.lock
kobelb added a commit that referenced this pull request Oct 24, 2018
@kobelb
Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 (#22816) (#24335)
ca8788f 
* Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0

* Fixing x-pack yarn.lock

* Switching x-pack to ^5.2.0

* Fixing yarn.lock
@kobelb kobelb changed the title Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 [REVERTED] Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 Oct 31, 2018
@kobelb kobelb changed the title [REVERTED] Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 Oct 31, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb kobelb changed the title Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 [REVERTED] Upgrading mocha to 5.2.0 and gulp-mocha to 6.0.0 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kobelb @elasticmachine @mistic @cjcenizal