Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v88.3.0 #166676

Merged
merged 18 commits into from Sep 20, 2023
Merged

Upgrade EUI to v88.3.0 #166676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4df9088
Upgrade EUI to v.88.3.0 . Update webpack.config to handle ES modules …
breehall Sep 12, 2023
1597988
[i18n] Update i18n tokens for EUI v.88.3.0
breehall Sep 12, 2023
882a2e3
[EuiAccordion] Update snapshots for tests capturing EuiAccordion as i…
breehall Sep 13, 2023
2c82f59
[EuiAccordion] Update reference to EuiAccordion's buttonIcon class as…
breehall Sep 13, 2023
159ba28
Merge branch 'main' into eui/88.3.0
kibanamachine Sep 13, 2023
cbf4406
[EuiAccordion] Remove unnecessary custom CSS in favor of a prop
cee-chen Sep 13, 2023
7a4ef14
[EuiAccordion] Update more references to renamed arrow class
cee-chen Sep 13, 2023
bb2d2f0
Add rule to Security Cypress Webpack config to allow optional chainin…
breehall Sep 13, 2023
27fe841
Updating changes made by kbn bootstrap
breehall Sep 13, 2023
d779250
Merge branch 'main' of github.com:breehall/kibana into eui/88.3.0
breehall Sep 14, 2023
ac66ef8
Merge branch 'main' into eui/88.3.0
jbudz Sep 18, 2023
3c4b9e2
Update storybook webpack config
cee-chen Sep 18, 2023
42aaf43
Merge branch 'main' into eui/88.3.0
cee-chen Sep 18, 2023
984486e
Pin `@hello-pangea/dnd` to 16.2.0
cee-chen Sep 19, 2023
da760a4
Merge remote-tracking branch 'upstream/main' into eui/88.3.0
cee-chen Sep 19, 2023
f0c5f35
Merge branch 'main' into eui/88.3.0
cee-chen Sep 19, 2023
197b8b1
Fix `@hello-pangea/dnd` type error
cee-chen Sep 19, 2023
48879ce
Restore removed `test/interpreter_functional/snapshots/session` files
cee-chen Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -77,6 +77,7 @@
"yarn": "^1.22.19"
},
"resolutions": {
"**/@hello-pangea/dnd": "16.2.0",
Copy link
Member Author

@cee-chen cee-chen Sep 19, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkajtoch @breehall

I don't love this but I don't see an easy way around this. We were able to update Kibana's base webpack config and Cypress webpack config to use the optional chaining babel plugin on the distributed dnd dependency, but Storybook just won't take my updated rule no matter what I try.

I think it's related to this issue: storybookjs/storybook#14292 and the fact that Kibana is still on Webpack v4. I don't think we can upgrade Kibana past 16.2.0 until it's on Webpack v5.

Edit: I tried the linked issue's suggestion of pinning acorn to 8.x, which fixed Storybook but unfortunately broke Kibana's build script. So we're stuck with pinning @hello-pangea/dnd until Kibana is on Webpack v5 I think.

"**/@types/node": "18.17.1",
"**/@typescript-eslint/utils": "5.62.0",
"**/chokidar": "^3.5.3",
Expand All @@ -100,7 +101,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.9.1-canary.1",
"@elastic/ems-client": "8.4.0",
"@elastic/eui": "88.2.0",
"@elastic/eui": "88.3.0",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand All @@ -125,7 +126,7 @@
"@hapi/hoek": "^9.2.1",
"@hapi/inert": "^6.0.4",
"@hapi/wreck": "^17.1.0",
"@hello-pangea/dnd": "^16.3.0",
"@hello-pangea/dnd": "16.2.0",
"@juggle/resize-observer": "^3.4.0",
"@kbn/aad-fixtures-plugin": "link:x-pack/test/alerting_api_integration/common/plugins/aad",
"@kbn/ace": "link:packages/kbn-ace",
Expand Down
389 changes: 192 additions & 197 deletions ...me/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 18 additions & 3 deletions packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx
View file
Open in desktop
Expand Up @@ -17,9 +17,12 @@ interface EuiValues {

export const getEuiContextMapping = (): EuiTokensObject => {
return {
'euiAccordion.isLoading': i18n.translate('core.euiAccordion.isLoading', {
defaultMessage: 'Loading',
}),
'euiAccordionChildrenLoading.message': i18n.translate(
'core.euiAccordionChildrenLoading.message',
{
defaultMessage: 'Loading',
}
),
'euiAutoRefresh.autoRefreshLabel': i18n.translate('core.euiAutoRefresh.autoRefreshLabel', {
defaultMessage: 'Auto refresh',
}),
Expand Down Expand Up @@ -419,6 +422,18 @@ export const getEuiContextMapping = (): EuiTokensObject => {
'There is a new region landmark called {landmarkHeading} with page level controls at the end of the document.',
values: { landmarkHeading },
}),
'euiGlobalToastList.clearAllToastsButtonAriaLabel': i18n.translate(
'core.euiGlobalToastList.clearAllToastsButtonAriaLabel',
{
defaultMessage: 'Clear all toast notifications',
}
),
'euiGlobalToastList.clearAllToastsButtonDisplayText': i18n.translate(
'core.euiGlobalToastList.clearAllToastsButtonDisplayText',
{
defaultMessage: 'Clear all',
}
),
'euiKeyboardShortcuts.title': i18n.translate('core.euiKeyboardShortcuts.title', {
defaultMessage: 'Keyboard shortcuts',
}),
Expand Down