Upgrade EUI to v88.3.0 #166676
Merged
Upgrade EUI to v88.3.0 #166676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the hellopangea/dnd dev dependency
…t recently was refactored and converted to Emotion.
… it is no longer being used after the components most recent refactor and Emotion conversion.
…g within hellopangea/dnd dev dependency
Merge in the latest from main
- to match other webpack config changes
cee-chen
added
release_note:skip
cee-chen
commented
Sep 19, 2023
| @@ -77,6 +77,7 @@ | |||
| "yarn": "^1.22.19" | |||
| }, | |||
| "resolutions": { | |||
| "**/@hello-pangea/dnd": "16.2.0", | |||
There was a problem hiding this comment.
I don't love this but I don't see an easy way around this. We were able to update Kibana's base webpack config and Cypress webpack config to use the optional chaining babel plugin on the distributed dnd dependency, but Storybook just won't take my updated rule no matter what I try.
I think it's related to this issue: storybookjs/storybook#14292 and the fact that Kibana is still on Webpack v4. I don't think we can upgrade Kibana past 16.2.0 until it's on Webpack v5.
Edit: I tried the linked issue's suggestion of pinning acorn to 8.x, which fixed Storybook but unfortunately broke Kibana's build script. So we're stuck with pinning @hello-pangea/dnd until Kibana is on Webpack v5 I think.
cee-chen
force-pushed
the
eui/88.3.0
branch
from
5d96895
to
02d4f75
Compare
cee-chen
force-pushed
the
eui/88.3.0
branch
from
0111383
to
da760a4
Compare
cee-chen
force-pushed
the
eui/88.3.0
branch
from
2bda46a
to
1bb9a98
Compare
- unclear why they were removed in the previous PR
cee-chen
force-pushed
the
eui/88.3.0
branch
from
1bb9a98
to
48879ce
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/eui-team (EUI) |
|
@elastic/kibana-operations Thanks again for your patience with us! 🙇 |
pgayvallet
approved these changes
Sep 20, 2023
eokoneyo
approved these changes
Sep 20, 2023
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Sep 21, 2023
⚠️ NOTE: This PR is a copy of elastic#166292 (which was reverted due to failing Storybook builds). This is the same exact PR but with Storybook building fixed. --- EUI `88.2.0` ➡️ `88.3.0` ## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0) - `EuiGlobalToastList` now shows a "Clear all" button by default once above a certain number of toasts (defaults to 3). This threshold is configurable with the `showClearAllButtonAt` prop ([elastic#7111](elastic/eui#7111)) - Added an optional `onClearAllToasts` callback to `EuiGlobalToastList` ([elastic#7111](elastic/eui#7111)) - Added the `value`, `onChange`, and `onCancel` props that allow `EuiInlineEdit` to be used as a controlled component ([elastic#7157](elastic/eui#7157)) - Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`, `transitionTopIn`, and `transitionTopOut` icon glyphs. ([elastic#7168](elastic/eui#7168)) **Bug fixes** - Fixed `EuiInlineEdit` components to correctly spread `...rest` attributes to the parent wrapper ([elastic#7157](elastic/eui#7157)) - Fixed `EuiListGroupItem` to correctly render the `extraAction` button when `showToolTip` is also passed ([elastic#7159](elastic/eui#7159)) **Dependency updates** - Updated `@hello-pangea/dnd` to v16.3.0 ([elastic#7125](elastic/eui#7125)) - Updated `@types/lodash` to v4.14.198 ([elastic#7126](elastic/eui#7126)) **Accessibility** - `EuiAccordion` now correctly respects reduced motion settings ([elastic#7161](elastic/eui#7161)) - `EuiAccordion` now shows a focus outline to keyboard users around its revealed children on open ([elastic#7161](elastic/eui#7161)) **CSS-in-JS conversions** - Converted `EuiSplitPanel` to Emotion ([elastic#7172](elastic/eui#7172)) --------- Co-authored-by: Bree Hall <briannajdhall@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EUI
88.2.0➡️88.3.088.3.0EuiGlobalToastListnow shows a "Clear all" button by default once above a certain number of toasts (defaults to 3). This threshold is configurable with theshowClearAllButtonAtprop (#7111)onClearAllToastscallback toEuiGlobalToastList(#7111)value,onChange, andonCancelprops that allowEuiInlineEditto be used as a controlled component (#7157)grabOmnidirectional,transitionLeftIn,transitionLeftOut,transitionTopIn, andtransitionTopOuticon glyphs. (#7168)Bug fixes
EuiInlineEditcomponents to correctly spread...restattributes to the parent wrapper (#7157)EuiListGroupItemto correctly render theextraActionbutton whenshowToolTipis also passed (#7159)Dependency updates
@hello-pangea/dndto v16.3.0 (#7125)@types/lodashto v4.14.198 (#7126)Accessibility
EuiAccordionnow correctly respects reduced motion settings (#7161)EuiAccordionnow shows a focus outline to keyboard users around its revealed children on open (#7161)CSS-in-JS conversions
EuiSplitPanelto Emotion (#7172)