Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA][Code Coverage] follow up pr for ftr auto config handling & fix merge #131734

Merged
merged 39 commits into from May 27, 2022
Merged

[QA][Code Coverage] follow up pr for ftr auto config handling & fix merge #131734

merged 39 commits into from May 27, 2022

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented May 6, 2022 •
edited

Summary

Embed buildkite pipeline definition.

Follow up pr to change cc per auto config handling.
Also, resolves #132706

Increase worker count for node scripts/build_kibana_platform_plugins to 4 workers.

Normalize file names within coverage files such that nyc correctly builds the combined summaries.
Ci runs this on myriad servers, so the paths are different, which "breaks" nyc's output

Split the final merge of functional coverage into 2 passes due to nyc issue

@wayneseymour wayneseymour self-assigned this May 6, 2022
@wayneseymour wayneseymour added code coverage Issues & PRs about code coverage skip-ci labels May 6, 2022
@wayneseymour wayneseymour changed the title [QA][Code Coverage] fixup for auto config handling [QA][Code Coverage] follow up pr for ftr auto config handling May 10, 2022
@wayneseymour wayneseymour force-pushed the ftr-auto-config-follow-up branch 3 times, most recently from 7efb033 to b8070ac Compare May 11, 2022 16:14
@wayneseymour wayneseymour force-pushed the ftr-auto-config-follow-up branch 3 times, most recently from 31d03db to 9bf50a8 Compare May 16, 2022 10:25
@wayneseymour wayneseymour requested a review from spalger May 17, 2022 15:15
@wayneseymour wayneseymour force-pushed the ftr-auto-config-follow-up branch 6 times, most recently from 2fe9479 to cebbad4 Compare May 23, 2022 13:30
@wayneseymour wayneseymour changed the title [QA][Code Coverage] follow up pr for ftr auto config handling [QA][Code Coverage] follow up pr for ftr auto config handling & fix merge May 23, 2022
@wayneseymour
Copy link
Member Author

passed in buildkite: https://buildkite.com/elastic/kibana-code-coverage-main/builds/441

@wayneseymour
[QA][Code Coverage] fixup for auto config handling
825b7fd 
Add support for automatic ftr config groups.
Add dasherize fn for unique names.
Bump pipeline lib version.
Force exit 0 to continue pipeline, so ingestion always happens.
Add dasherize fn for unique names
Split merge into two passes.
Add debugging utility fns.
@wayneseymour wayneseymour marked this pull request as ready for review May 23, 2022 15:37
@wayneseymour wayneseymour requested review from a team as code owners May 23, 2022 15:37
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 23, 2022
wayneseymour and others added 10 commits May 25, 2022 10:40
@wayneseymour
A recent run said it could not find filHeads, try again.
2c162c2 
It's sourced it so it should be available.
@wayneseymour
Change replacePaths and clean_coverage_paths to be used normalize the…
09d8933 
… paths in all stages.
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
1929e81 
…-ref HEAD~1..HEAD --fix'
@wayneseymour
Change replacePaths and clean_coverage_paths to be used normalize the…
833420f 
… paths in all stages; update fileHeads to operate on more than just json
@wayneseymour
Merge branch 'ftr-auto-config-follow-up' of github.com:elastic/kibana…
2bd6dbf 
… into ftr-auto-config-follow-up
@wayneseymour
Change replacePaths and clean_coverage_paths to be used normalize the…
ac41979 
… paths in all stages; update fileHeads to operate on more than just json, and

drop some debugging
@wayneseymour
Show me jest-combined after jest parallel.
32ed530
@wayneseymour
With dima; replace paths and merge in parallel, not afterwards.
b1cbd9c
@wayneseymour
Drop much of the extra output
8c7c893
@wayneseymour
Cleanup.
6730c2f
@wayneseymour wayneseymour force-pushed the ftr-auto-config-follow-up branch 2 times, most recently from 1ffb654 to 6730c2f Compare May 26, 2022 12:35
LeeDr
LeeDr approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results of this PR in kibana-stats cluster LGTM

@wayneseymour
Copy link
Member Author

@elastic/kibana-operations may I have a yay / nay on this soon pretty please?

brianseeders
brianseeders reviewed May 26, 2022
View reviewed changes
.buildkite/pipelines/code_coverage/daily.yml Outdated
@@ -0,0 +1,41 @@
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend moving these Slack notification settings to the pipeline yaml at buildkite.com, e.g. here https://buildkite.com/elastic/kibana-code-coverage-main/steps

If, for example, this yml file can't be parsed when calling buildkite-agent pipeline upload you won't be notified about it. You will, however, if it's in the other yml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, thanks so much!

brianseeders
brianseeders reviewed May 26, 2022
View reviewed changes
.buildkite/pipelines/code_coverage/daily.yml Outdated
SLACK_NOTIFICATIONS_CHANNEL: "#kibana-qa"
SLACK_NOTIFICATIONS_ENABLED: "true"
CODE_COVERAGE: 1
notify:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SLACK_NOTIFICATIONS_ENABLED env vars above are for our custom Slack notifier, but this notify: block is for the one that's built-in to Buildkite, so you should probably pick one and remove the other.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is best?

@wayneseymour
Drop original yml config.
a16c8ab 
Drop wait step.
Run "git checkout upstream/main -- .buildkite/package-lock.json".
Drop notify in favor of the operations team's slack notifications.
Place env block in buildkite config in the ui, remove them from the repo.
@wayneseymour
Merge branch 'ftr-auto-config-follow-up' of github.com:elastic/kibana…
ff4f1ea 
… into ftr-auto-config-follow-up
@wayneseymour
Drop continue on failure step.
750f0a1
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit 5f950e6 into main May 27, 2022
@wayneseymour wayneseymour deleted the ftr-auto-config-follow-up branch May 27, 2022 11:28
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 131734 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 31, 2022
@wayneseymour wayneseymour added the backport:skip This commit does not require backporting label May 31, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 31, 2022
@kibanamachine kibanamachine mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders left review comments

@spalger spalger spalger approved these changes

@LeeDr LeeDr LeeDr approved these changes

@jbudz jbudz Awaiting requested review from jbudz

@dmlemeshko dmlemeshko Awaiting requested review from dmlemeshko

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA][Code Coverage] Merging failing
8 participants
@wayneseymour @dmlemeshko @kibana-ci @kibanamachine @brianseeders @spalger @jbudz @LeeDr