Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[QA][Code Coverage] fixup for auto config handling
Add support for automatic ftr config groups. Add dasherize fn for unique names. Bump pipeline lib version. Force exit 0 to continue pipeline, so ingestion always happens. Add dasherize fn for unique names Split merge into two passes. Add debugging utility fns.
- Loading branch information
1 parent
a487d7c
commit 825b7fd
Showing
15 changed files
with
403 additions
and
204 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
.buildkite/scripts/steps/code_coverage/clean_coverage_paths.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| const { readFileSync, writeFileSync } = require('fs'); | ||
| const FILE = process.argv[2]; | ||
| console.log(`\n### process.env.KIBANA_DIR: \n\t${process.env.KIBANA_DIR}`); | ||
| console.log(`\n\t### Replacing paths in: \n\t${FILE}`); | ||
| // TODO-TRE: Drop hardcoded replacement | ||
| writeFileSync(FILE, readFileSync(FILE).toString().replaceAll(process.env.KIBANA_DIR, 'LEETRE')); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| source .buildkite/scripts/common/util.sh | ||
| source .buildkite/scripts/steps/code_coverage/util.sh | ||
|
|
||
| export CODE_COVERAGE=1 # Kibana is bootstrapped differently for code coverage | ||
| echo "--- Print KIBANA_DIR" | ||
| echo "### KIBANA_DIR: $KIBANA_DIR" | ||
| .buildkite/scripts/bootstrap.sh | ||
|
|
||
| echo "--- Build Platform Plugins" | ||
| NODE_OPTIONS=--max_old_space_size=14336 node scripts/build_kibana_platform_plugins \ | ||
| --no-examples --test-plugins --workers 4 | ||
|
|
||
| is_test_execution_step | ||
|
|
||
| export JOB_NUM=$BUILDKITE_PARALLEL_JOB | ||
| export JOB=ftr-configs-${JOB_NUM} | ||
|
|
||
| FAILED_CONFIGS_KEY="${BUILDKITE_STEP_ID}${BUILDKITE_PARALLEL_JOB:-0}" | ||
|
|
||
| # a FTR failure will result in the script returning an exit code of 10 | ||
| exitCode=0 | ||
|
|
||
| configs="${FTR_CONFIG:-}" | ||
|
|
||
| if [[ "$configs" == "" ]]; then | ||
| echo "--- downloading ftr test run order" | ||
| buildkite-agent artifact download ftr_run_order.json . | ||
| # configs=$(jq -r '.groups[env.JOB_NUM | tonumber].names | first' ftr_run_order.json) | ||
| configs=$(jq -r '.groups[env.JOB_NUM | tonumber].names | .[]' ftr_run_order.json) | ||
| fi | ||
|
|
||
| echo "### Configs" | ||
| echo $configs | ||
|
|
||
| failedConfigs="" | ||
| results=() | ||
|
|
||
| while read -r config; do | ||
| if [[ ! "$config" ]]; then | ||
| continue | ||
| fi | ||
|
|
||
| echo "--- Print config name" | ||
| echo "### config: $config" | ||
|
|
||
| echo "--- $ node scripts/functional_tests --config $config --exclude-tag ''skipCoverage''" | ||
| start=$(date +%s) | ||
|
|
||
| # prevent non-zero exit code from breaking the loop | ||
| set +e | ||
| NODE_OPTIONS=--max_old_space_size=16384 \ | ||
| ./node_modules/.bin/nyc \ | ||
| --nycrc-path ./src/dev/code_coverage/nyc_config/nyc.server.config.js \ | ||
| node scripts/functional_tests \ | ||
| --config="$config" \ | ||
| --exclude-tag "skipCoverage" | ||
| lastCode=$? | ||
| set -e | ||
|
|
||
| dasherize() { | ||
| withoutExtension=${1%.*} | ||
| dasherized=$(echo "$withoutExtension" | tr '\/' '\-') | ||
| } | ||
| dasherize $config | ||
|
|
||
| if [[ -d "$KIBANA_DIR/target/kibana-coverage/functional" ]]; then | ||
| echo "--- Server and / or Client side code coverage collected" | ||
| if [[ -f "target/kibana-coverage/functional/coverage-final.json" ]]; then | ||
| mv target/kibana-coverage/functional/coverage-final.json "target/kibana-coverage/functional/${dasherized}-server-coverage.json" | ||
| fi | ||
| fi | ||
| # echo "--- Replace paths in configs loop, for SERVER COVERAGE" | ||
| # replacePaths "$KIBANA_DIR/target/kibana-coverage/functional" | ||
|
|
||
| timeSec=$(($(date +%s) - start)) | ||
| if [[ $timeSec -gt 60 ]]; then | ||
| min=$((timeSec / 60)) | ||
| sec=$((timeSec - (min * 60))) | ||
| duration="${min}m ${sec}s" | ||
| else | ||
| duration="${timeSec}s" | ||
| fi | ||
|
|
||
| results+=("- $config | ||
| duration: ${duration} | ||
| result: ${lastCode}") | ||
|
|
||
| if [ $lastCode -ne 0 ]; then | ||
| exitCode=10 | ||
| echo "FTR exited with code $lastCode" | ||
| echo "^^^ +++" | ||
|
|
||
| if [[ "$failedConfigs" ]]; then | ||
| failedConfigs="${failedConfigs}"$'\n'"$config" | ||
| else | ||
| failedConfigs="$config" | ||
| fi | ||
| fi | ||
|
|
||
| dirListing "target/dir-listing-$dasherized.txt" target/kibana-coverage/functional | ||
| done <<<"$configs" | ||
|
|
||
| #dirListing "target/dir-listing-functional-post-loop.txt" target/kibana-coverage/functional | ||
| #fileHeads "target/file-heads-functional-post-loop.txt" target/kibana-coverage/functional | ||
|
|
||
| # Each browser unload event, creates a new coverage file. | ||
| # So, we merge them here. | ||
| if [[ -d "$KIBANA_DIR/target/kibana-coverage/functional" ]]; then | ||
| echo "--- Merging code coverage for FTR Configs" | ||
| NODE_OPTIONS=--max_old_space_size=16384 yarn nyc report \ | ||
| --nycrc-path src/dev/code_coverage/nyc_config/nyc.functional.config.js --reporter json | ||
| rm -rf target/kibana-coverage/functional/* | ||
| mv target/kibana-coverage/functional-combined/coverage-final.json \ | ||
| "target/kibana-coverage/functional/$(date +%s)-coverage-final.json" | ||
| else | ||
| echo "--- Code coverage not found in: $KIBANA_DIR/target/kibana-coverage/functional" | ||
| fi | ||
|
|
||
| #dirListing "target/dir-listing-functional-post-merge.txt" target/kibana-coverage/functional | ||
| #fileHeads "target/file-heads-functional-post-merge-before-replace.txt" target/kibana-coverage/functional | ||
|
|
||
| echo "--- Replace paths OUTSIDE OF configs loop, FOR FUNCTIONAL COVERAGE" | ||
| replacePaths "$KIBANA_DIR/target/kibana-coverage/functional" | ||
| #fileHeads "target/file-heads-functional-after-replace.txt" target/kibana-coverage/functional | ||
|
|
||
| if [[ "$failedConfigs" ]]; then | ||
| buildkite-agent meta-data set "$FAILED_CONFIGS_KEY" "$failedConfigs" | ||
| fi | ||
|
|
||
| echo "--- FTR configs complete" | ||
| printf "%s\n" "${results[@]}" | ||
| echo "" | ||
|
|
||
| # Force exit 0 to ensure the next build step starts. | ||
| exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.