Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node to 16.11.1 #110684

Merged
merged 28 commits into from Oct 16, 2021
Merged

Bump node to 16.11.1 #110684

merged 28 commits into from Oct 16, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Aug 31, 2021 •
edited

Closes #98650

[skip-ci]

@jbudz

This comment has been minimized.

Sign in to view
@jbudz jbudz changed the title Bump node to 16.8.0 Bump node to 16.9.0 Sep 10, 2021
@jbudz

This comment has been minimized.

Sign in to view
@jbudz jbudz changed the title Bump node to 16.9.0 Bump node to 16.9.1 Sep 20, 2021
@jbudz

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@kibanamachine

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@kibanamachine

This comment has been minimized.

Sign in to view
@jbudz
Copy link
Member Author

jbudz commented Sep 29, 2021

FTR groups look okay now. Next up:

  1. jest 26 types are incompatible with node 16 types - https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/156523/execution/node/428/log/
  2. jest tests take ~45 minutes longer to run

@mshustov
Copy link
Contributor

jest 26 types are incompatible with node 16 types

@jbudz can we work around the problem by augmenting the global interface jestjs/jest#11640 (comment)? Update to jest v27 might be a significant effort (fixed in v27.1.0 jestjs/jest#11645 (comment))

jest tests take ~45 minutes longer to run

Can be fixed in a follow-up?

@jbudz

This comment has been minimized.

Sign in to view
@jbudz jbudz changed the title Bump node to 16.9.1 Bump node to 16.10.0 Oct 3, 2021
@jbudz

This comment has been minimized.

Sign in to view
@jbudz jbudz added Team:Operations Team label for Operations Team v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged labels Oct 4, 2021
@jbudz
Copy link
Member Author

jbudz commented Oct 4, 2021 •
edited

There's a few remaining issues that I don't have domain knowledge on - if anyone has spare cycles to take a look, assistance would be appreciated. I'll work through them as best I can if not.

I'd recommend opening this up in a separate workspace, ts refs won't be cached. Feel free to push directly to the branch.

Jest

Types

Deprecations

@kibanamachine

This comment has been minimized.

Sign in to view
@crob611 crob611 mentioned this pull request Oct 14, 2021
Closed
byronhulcher
byronhulcher approved these changes Oct 14, 2021
View reviewed changes
.../public/applications/app_search/components/document_creation/document_creation_logic.test.ts
@@ -493,7 +493,7 @@ describe('DocumentCreationLogic', () => {
await nextTick();

expect(DocumentCreationLogic.actions.setErrors).toHaveBeenCalledWith(
"Cannot read property 'total' of undefined"
"Cannot read properties of undefined (reading 'total')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this for us

@jbudz
Copy link
Member Author

jbudz commented Oct 14, 2021

@elasticmachine merge upstream

@rudolf
Copy link
Contributor

rudolf commented Oct 15, 2021

Gattling report for "DemoJourney" shows a ~21% improvement in response times :D
Screenshot 2021-10-15 at 14 52 14

@jbudz jbudz mentioned this pull request Oct 15, 2021
Closed
@jbudz
Copy link
Member Author

jbudz commented Oct 15, 2021

@elasticmachine merge upstream

@jbudz jbudz requested a review from a team as a code owner October 16, 2021 02:25
@jbudz
Copy link
Member Author

jbudz commented Oct 16, 2021

buildkite, test this

1 similar comment
@jbudz
Copy link
Member Author

jbudz commented Oct 16, 2021

buildkite, test this

@jbudz
Copy link
Member Author

jbudz commented Oct 16, 2021

[job] [logs] Jest Tests / when using the ArtifactEntryCard component with trusted apps should display dates in expected format

Flaky upstream - #113892

@jbudz
Copy link
Member Author

jbudz commented Oct 16, 2021

buildkite, test this

@jbudz jbudz removed the auto-backport Deprecated: Automatically backport this PR after it's merged label Oct 16, 2021
@jbudz jbudz mentioned this pull request Oct 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 7d66002 into elastic:master Oct 16, 2021
@jbudz jbudz deleted the bump-node-16.8.0 branch October 16, 2021 21:22
@jbudz
Copy link
Member Author

jbudz commented Oct 16, 2021 •
edited

Thanks for the reviews and assistance everyone. I've updated #112699 noting now skipped tests.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 18, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/poc…
6b639dd 
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (237 commits)
  [Uptime] Added uptime query inspector panel (elastic#115170)
  [Osquery] Add packs (elastic#107345)
  [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188)
  [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671)
  skip flaky tests.  elastic#115308, elastic#115313
  [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495)
  skip flaky suite.  elastic#107057
  skip flaky tests. elastic#89052, elastic#113418, elastic#115304
  skip flaky test. elastic#113892
  Bump node to 16.11.1 (elastic#110684)
  [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742)
  skip flaky suite.  elastic#115130
  one line remove assert (elastic#115127)
  Fixes migration bug where I was deleting attributes (elastic#115098)
  [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal  (elastic#114214)
  [build] Dockerfile update (elastic#115237)
  Fixes Cypress flake cypress test (elastic#115270)
  Disable APM e2e tests
  log an invalid type for SO (elastic#115175)
  [Fleet] Don't auto upgrade policies for AUTO_UPDATE packages (elastic#115199)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/types.ts
#	x-pack/plugins/reporting/server/lib/layouts/print_layout.ts
@cnasikas cnasikas mentioned this pull request Oct 18, 2021
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 18, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
36426c6 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (287 commits)
  [Security Solution][Endpoint] Change `trustedAppByPolicyEnabled` flag to `true` by default (elastic#115264)
  [APM] generator: support error events and application metrics (elastic#115311)
  [kibanaUtils] Don't import full `semver` client side (elastic#114986)
  [RAC] Link inventory alerts to the right inventory view (elastic#113553)
  [Uptime] Added uptime query inspector panel (elastic#115170)
  [Osquery] Add packs (elastic#107345)
  [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188)
  [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671)
  skip flaky tests.  elastic#115308, elastic#115313
  [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495)
  skip flaky suite.  elastic#107057
  skip flaky tests. elastic#89052, elastic#113418, elastic#115304
  skip flaky test. elastic#113892
  Bump node to 16.11.1 (elastic#110684)
  [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742)
  skip flaky suite.  elastic#115130
  one line remove assert (elastic#115127)
  Fixes migration bug where I was deleting attributes (elastic#115098)
  [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal  (elastic#114214)
  [build] Dockerfile update (elastic#115237)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@jbudz @rudolf
@kibanamachine @artem-shelkovnikov
Bump node to 16.11.1 (elastic#110684)
3fb11f5 
* Bump node to ^16

* fix comment

* use jest timers

* bump mock-fs

* Fix core type errors

* Unskipping tests that work on my machine

* skip new unhandled promise rejection

* Fix Nodejs v16 regression due to nodejs/node#38924

* Fix failing concurrent connections collector test

* Fix types after merge from master

* update servicenow test

* Skip unhandledRejection tests

* Skip tests with unhandled promise rejection

* Fix discover jest failures

* bump node to 16.11.1

* revert timeout increase

* skip unhandled promise rejection

* rm jest import

* skip unhandled promise rejection

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tim Roes <tim.roes@elastic.co>
@mshustov mshustov mentioned this pull request Nov 30, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

@crob611 crob611 crob611 approved these changes

@timroes timroes timroes approved these changes

@spalger spalger spalger approved these changes

@flash1293 flash1293 flash1293 approved these changes

@joshdover joshdover joshdover approved these changes

@byronhulcher byronhulcher byronhulcher approved these changes

@spong spong spong approved these changes

@mshustov mshustov mshustov approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jloleysens jloleysens jloleysens approved these changes

@dasansol92 dasansol92 dasansol92 approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
backported buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 16.x