Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Resolve validation bug with empty params on connector's integration test #102955

Closed
cnasikas opened this issue Jun 22, 2021 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Actions NeededFor:Security Solution SIEM, Endpoint, Timeline, Analyzer, Cases Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.0.0

Comments

@cnasikas
Copy link
Member

cnasikas commented Jun 22, 2021

Some connectors has an integration test where it checks if the validation success when no params are being passed.

This PR changed the validation check and added the following comment. The issue should research and investigate if it can be resolved.

// Node.js 12 oddity:
// The first time after the server is booted, the error message will be:
//
//     undefined is not iterable (cannot read property Symbol(Symbol.iterator))
//
// After this, the error will be:
//
//     Cannot destructure property 'value' of 'undefined' as it is undefined.
//
// The error seems to come from the exact same place in the code based on the
// exact same circumstances:
//
//     https://github.com/elastic/kibana/blob/b0a223ebcbac7e404e8ae6da23b2cc6a4b509ff1/packages/kbn-config-schema/src/types/literal_type.ts#L28
//
// What triggers the error is that the `handleError` function expects its 2nd
// argument to be an object containing a `valids` property of type array.
//
// In this test the object does not contain a `valids` property, so hence the
// error.
// Why the error message isn't the same in all scenarios is unknown to me and
// could be a bug in V8.
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 22, 2021
@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Threat Hunting Security Solution Threat Hunting Team v8.0.0 and removed needs-team Issues missing a team label labels Jun 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@gmmorris gmmorris added Feature:Actions Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework NeededFor:Security Solution SIEM, Endpoint, Timeline, Analyzer, Cases labels Jul 1, 2021
@mikecote mikecote added this to Backlog in Kibana Alerting Jul 28, 2021
@gmmorris gmmorris added the loe:needs-research This issue requires some research before it can be worked on or estimated label Aug 11, 2021
@gmmorris gmmorris added the estimate:needs-research Estimated as too large and requires research to break down into workable issues label Aug 18, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@gmmorris
Copy link
Contributor

@cnasikas - is this a SN specific thing? or is this broader and applies to other Connector Types?

@cnasikas
Copy link
Member Author

cnasikas commented Oct 18, 2021

@gmmorris It is specific to the incident management connectors that they have the subAction parameter. I think it has to do with the @kbn/config-schema. This PR #110684 improved it and this PR #114125 will fix it by checking only the status of the response and not the message as it is not important. I am closing the issue as there is no need to investigate.

Kibana Alerting automation moved this from Backlog to Done (Ordered by most recent) Oct 18, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Actions NeededFor:Security Solution SIEM, Endpoint, Timeline, Analyzer, Cases Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.0.0
Projects
No open projects
Kibana Alerting
Done (Ordered by most recent)
Development

No branches or pull requests

4 participants