Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Doc+) Delineate Bootstrapping Data Stream from Alias #107976

Merged
merged 2 commits into from May 2, 2024

Conversation

stefnestor
Copy link
Contributor

👋 howdy, team!

This is follow-up to elasticsearch#107327. I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. (Sorry again.)

However, it seemed like a good opportunity to (A) fill in links & (B) consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Applied forward earlier feedback.

Thoughts? cc: @dakrone

👋 howdy, team! 

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?
@stefnestor stefnestor added >enhancement >docs General docs changes :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Apr 26, 2024
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v8.15.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@shainaraskas shainaraskas self-requested a review April 29, 2024 15:33
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

docs/reference/ilm/ilm-tutorial.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@stefnestor stefnestor merged commit a3f3f59 into main May 2, 2024
6 checks passed
@stefnestor stefnestor deleted the stefnestor-patch-6 branch May 2, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >docs General docs changes >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants