New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add domain fitting #510
feat: add domain fitting #510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 84.59% 84.54% -0.05%
==========================================
Files 158 169 +11
Lines 4738 4912 +174
Branches 967 959 -8
==========================================
+ Hits 4008 4153 +145
- Misses 715 743 +28
- Partials 15 16 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great to me! I appreciate the clearness in the domain tests
and the new axis story you have written- 'fit domain to extent in y axis'
both changes make it very clear what this PR is accomplishing. Also, thanks for the help with the prettier updates, once I quit my VSCode and brought it back, the new prettier didn't cause any problems. So all those prettier changes look great too!
# [16.1.0](v16.0.2...v16.1.0) (2020-01-08) ### Features * add domain fitting ([#510](#510)) ([fefe728](fefe728))
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* Add option to fit y domain to data
* feat: add domain fitting (#510) * Add option to fit y domain to data * Remove story cuz vr tests are failing to run * fix bad type
# [16.1.0](elastic/elastic-charts@v16.0.2...v16.1.0) (2020-01-08) ### Features * add domain fitting ([opensearch-project#510](elastic/elastic-charts#510)) ([8d3c44f](elastic/elastic-charts@8d3c44f))
Summary
fit
option toAxis.domain
option. This will fit the domain to the given data. if the min or max is near but not over 0 it will use 0 as the baseline.Related to https://github.com/elastic/sdh-kibana/issues/176
Fixes elastic/kibana#53257
Positive
Before
After
Positive & Negative
Before
After
Negative
Before
After
Checklist