Add domain fit option for 0 opacity tsvb line charts #54314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
Feature:TSVB
💚 Build SucceededTo update your PR or re-run it, just comment with: |
TinaHeiligers
approved these changes
Jan 9, 2020
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Jan 9, 2020
…4314) - Line charts is TSVB will no again fit to the data and provide a padding when away from the zero baseline
dgieselaar
pushed a commit
to ogupte/kibana
that referenced
this pull request
Jan 10, 2020
…4314) - Line charts is TSVB will no again fit to the data and provide a padding when away from the zero baseline
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Jan 10, 2020
…4314) - Line charts is TSVB will no again fit to the data and provide a padding when away from the zero baseline
nickofthyme
added a commit
that referenced
this pull request
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds fitting to 0 opacity TSVB "line" charts. Area charts, with non-zero opacity, will continue to have a zero baseline but "line" chart will fit the domain to the data.
Fixes #53257
Related to elastic/elastic-charts#510
Demo
Notice the difference between the 50% opacity and 0% opacity series.
Checklist
For maintainers