Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Feature - Add failsafe mode to generally manage integration-test #552

Closed
ningod opened this issue Jan 11, 2017 · 3 comments
Closed

Request Feature - Add failsafe mode to generally manage integration-test #552

ningod opened this issue Jan 11, 2017 · 3 comments

Comments

@ningod
Copy link

ningod commented Jan 11, 2017

In my project i use frontend maven plugin to execute integration-test with protractor testing framework, in my configuration i launch protractor using yarn goal and a script in package.json , but if tests fails all build fails and post-integration-test phase is never executed.
Due to this I need something to ignore plugin failure, a failOnError property or something similar to karma behavior with the "maven.test.failure.ignore" property
@eirslett
Copy link
Owner

We do have that property for the karma mojo, I think. I just cannot remember what it's called. Check the examples, or maybe in the code!

@ningod
Copy link
Author

ningod commented Jan 11, 2017

Yes, we have in karma but I'm not executing karma tests... I need it in other goals.
I'm moving the property from karma mojo to parent class then I'll pull a request to you

@ningod ningod mentioned this issue Jan 11, 2017
Closed
@kaqqao kaqqao mentioned this issue Feb 10, 2017
Open
@kaqqao
Copy link

kaqqao commented Feb 10, 2017 •
edited

This duplicates my issue #534
but the related pull request seems more complete than mine, so I'd favor this one over mine.

jcarsique pushed a commit to jcarsique/frontend-maven-plugin that referenced this issue Feb 20, 2017
@jcarsique
Fix eirslett#552: added maven.frontend.failOnError property and moved…
a121e7c 
… maven.test.failure.ignore property from KarmaRunMojo to AbstractFrontendMojo to manage integration-test phases

updated README.md and CHANGELOG.md
jcarsique added a commit to jcarsique/frontend-maven-plugin that referenced this issue Feb 20, 2017
@jcarsique
Fix eirslett#552: review PR eirslett#553, add failOnError and maven.t…
39bcb48 
…est.failure.ignore properties

fix integration-test
eval failOnError depending on the property set and isTestingPhase()
@jcarsique jcarsique mentioned this issue Feb 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaqqao @eirslett @ningod