chore(deps): upgrade postcss-modules #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables exportGlobals option
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 92.68% 92.50% -0.19%
==========================================
Files 10 10
Lines 328 320 -8
Branches 115 113 -2
==========================================
- Hits 304 296 -8
Misses 23 23
Partials 1 1
Continue to review full report at Codecov.
|
|
Please can you bump this to 3.2.1? This includes this fix (madyankin/postcss-modules#111) which we need. |
pascalduez
added a commit
to pascalduez/react-module-boilerplate
that referenced
this pull request
Aug 20, 2020
- Fix duplicated rules - Temporary until egoist/rollup-plugin-postcss#310 is published
|
@egoist It seems like there are no breaking changes in https://github.com/css-modules/postcss-modules/blob/master/CHANGELOG.md. I think it's good to go but making sure you see this before merging. |
|
Thanks for your PR and sorry for the delay, it seems that #342 already fixes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
exportGlobalsoption. I also added a test, to make sure this works as expected.