Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to latest safe deps #290

Closed
wants to merge 2 commits into from
Closed

Updated to latest safe deps #290

wants to merge 2 commits into from

Conversation

Akkuma
Copy link

@Akkuma Akkuma commented Jun 25, 2020

exportGlobals was just added to postcss-modules, which I need, but I updated the deps simultaneously w/o letting the tests fail.

exportGlobals was just added
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          10       10           
  Lines         319      319           
  Branches      112      112           
=======================================
  Hits          295      295           
  Misses         23       23           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9489eca...2491cdc. Read the comment docs.

@Akkuma Akkuma marked this pull request as ready for review June 25, 2020 21:08
@Akkuma
Copy link
Author

Akkuma commented Jun 25, 2020

As an fyi, updating rollup/bili seems to break rollup-plugin-postcss tests

@Akkuma Akkuma changed the title Updated to latest postcss-modules Updated to latest safe deps Jun 25, 2020
@benmccann
Copy link
Contributor

duplicate of #310

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 6, 2020

Thanks for your PR and sorry for the delay, it seems that #342 already fixes this.

@wardpeet wardpeet closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants