GH-1156 bump jline version #2543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
|
Wow, that build failure looks scary - vm crash. Might that be due to those memory problems you mentioned on the issue ticket? |
|
It might be. "Funny" thing, the tests were all green in Netbeans on my Windows laptop, so it might have something to do with 'dumb' terminal vs a fully functional one... |
1 task
|
@barthanssens given the scary error and the lack of a path forward, should we just close this for now? |
|
Yeah I think the path forward is actually a more or less full rewrite (see #1394). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bart Hanssens bart.hanssens@bosa.fgov.be
GitHub issue resolved: #1156
Briefly describe the changes proposed in this PR:
Upgrade jline dependency to version 3.16
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.