Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console: upgrade JLine dependency #1156

Closed
1 task done
barthanssens opened this issue Oct 30, 2018 · 4 comments
Closed
1 task done

Console: upgrade JLine dependency #1156

barthanssens opened this issue Oct 30, 2018 · 4 comments
Assignees
@barthanssens
Labels
📦 console affects the RDF4J Console CLI 📶 enhancement issue is a new feature or improvement wontfix issue won't be fixed (close reason)
Projects
Project Progress

Comments

@barthanssens
Copy link
Contributor

barthanssens commented Oct 30, 2018 •
edited

Upgrade JLine from 3.5.1 to e.g. 3.8.2 3.16,

And check if it's worth the effort to replace the bundled jar by a series of more fine grained jars (jline-terminal / jline-terminal-jansi / jline-reader / jline-style / jline-builtins / jline-console). This will require a few CQs

  • JLine3 parent CQ 22622
@barthanssens barthanssens added 📶 enhancement issue is a new feature or improvement rdf4j-tools labels Oct 30, 2018
@barthanssens barthanssens self-assigned this Oct 30, 2018
@barthanssens
Copy link
Contributor Author

Actually there already is an approved CQ for using 3.6.2 (CQ 16792), already an improvement

@barthanssens barthanssens added the ✋ CQ-Pending requires a CQ to be approved label Dec 13, 2018
@abrokenjester abrokenjester added the 📦 console affects the RDF4J Console CLI label Dec 26, 2018
@abrokenjester abrokenjester added this to To do in Project Progress May 1, 2020
@barthanssens barthanssens moved this from 📋 Backlog to 🚧 In progress in Project Progress Sep 25, 2020
@barthanssens barthanssens added this to the 3.5.0 milestone Sep 25, 2020
@barthanssens
Copy link
Contributor Author

Replacing the bundled jar with smaller jars doesn't make that much (size) difference, but it would require more CQ's and entries in the pom / more jars, so probably not worth the effort...

@abrokenjester abrokenjester moved this from 🚧 In progress to 🛑 Blocked in Project Progress Sep 28, 2020
barthanssens added a commit to Fedict/rdf4j that referenced this issue Sep 28, 2020
@barthanssens
eclipse-rdf4jGH-1156 bump jline version
b07b1e3 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
This was referenced Sep 28, 2020
Closed
Closed
@barthanssens
Copy link
Contributor Author

barthanssens commented Sep 28, 2020 •
edited

Seems that, starting with JLine 3.8, ConvertTest and UtilTest bump into memory issue jline/jline3#477 (linux, OpenJDK11, 1 GB heap space)

@barthanssens barthanssens removed the ✋ CQ-Pending requires a CQ to be approved label Sep 28, 2020
@abrokenjester abrokenjester linked a pull request Oct 26, 2020 that will close this issue
GH-1156 bump jline version #2543
Closed
5 tasks
@abrokenjester abrokenjester removed this from the 3.5.0 milestone Dec 2, 2020
@barthanssens barthanssens added the wontfix issue won't be fixed (close reason) label Apr 9, 2021
@barthanssens
Copy link
Contributor Author

See #1394

Project Progress automation moved this from 🛑 Blocked to 🥳 Done Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthanssens barthanssens

Labels
📦 console affects the RDF4J Console CLI 📶 enhancement issue is a new feature or improvement wontfix issue won't be fixed (close reason)
Projects
No open projects
Project Progress
🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-1156 bump jline version Fedict/rdf4j
2 participants
@abrokenjester @barthanssens