Do not use runReadOnly during TypeHierarchyViewPart.updateViewers #1408 #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipse-jdt#1408 partial revert of fc6a25a The used firePostSelectionChanged may run events that try to edit java model. fixes eclipse-jdt#1408 Since "Increase JavaModelCache #1929" its not a performance impact anymore anyway, since the jdt.core typically keeps a cached JavaModel of the TypeHierarchy after computing it anyway and does not need to compute it in ui again.
iloveeclipse
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial revert of fc6a25a
The used firePostSelectionChanged may run events that try to edit java model.
fixes #1408
Since "Increase JavaModelCache #1929" its not a performance impact anymore anyway, since the jdt.core typically keeps a cached JavaModel of the TypeHierarchy after computing it anyway and does not need to compute it in ui again.