Skip to content

Commit

Permalink
Do not use runReadOnly during TypeHierarchyViewPart.updateViewers #1408
Browse files Browse the repository at this point in the history
partial revert of fc6a25a

The used firePostSelectionChanged may run events that try to edit java
model.

fixes #1408

Since "Increase JavaModelCache #1929" its not a performance impact
anymore anyway, since the jdt.core typically keeps a cached JavaModel of
the TypeHierarchy after computing it anyway and does not need to compute
it in ui again.
  • Loading branch information
EcljpseB0T authored and jukzi committed May 16, 2024
1 parent f8121d1 commit 582704e
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,8 @@ protected void doHierarchyRefreshBackground(final IJavaElement[] elements, final
}
if (pm.isCanceled())
return;
JavaCore.runReadOnly(() -> {
fTypeHierarchyViewPart.setViewersInput();
fTypeHierarchyViewPart.updateViewers();
});
fTypeHierarchyViewPart.setViewersInput();
fTypeHierarchyViewPart.updateViewers();
});
}
}
Expand Down

0 comments on commit 582704e

Please sign in to comment.