Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update GH Action & Cypress dependencies for a successful build. #117

Merged
merged 3 commits into from Dec 16, 2020
Merged

ci: update GH Action & Cypress dependencies for a successful build. #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99bd926
update actions/setup-node to 2.1.2
cball Dec 13, 2020
7c5557b
update vercel-action to amondnet/vercel-action@v20.
cball Dec 13, 2020
4ce0bee
fixes Cypress issues
cball Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node
uses: actions/setup-node@v2.1.1
uses: actions/setup-node@v2.1.2
with:
node-version: 14.6.0
registry-url: https://registry.npmjs.org
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node
uses: actions/setup-node@v2.1.1
uses: actions/setup-node@v2.1.2
with:
node-version: ${{ matrix.node-version }}
- name: Find yarn cache location
Expand Down
6 changes: 3 additions & 3 deletions packages/create-bison-app/template/.github/workflows/main.js.yml.ejs
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ jobs:

# Node
- name: Setup Node
uses: actions/setup-node@v2.1.1
uses: actions/setup-node@v2.1.2
with:
node-version: 14.6.0

Expand Down Expand Up @@ -125,14 +125,14 @@ jobs:
steps:
- uses: actions/checkout@v2
<% if (host.name === 'vercel') { -%>
- uses: ngduc/vercel-deploy-action@master
- uses: amondnet/vercel-action@v20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
github-token: ${{ secrets.GITHUB_TOKEN }}
vercel-org-id: ${{ secrets.VERCEL_ORG_ID}}
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID}}
# SET THIS OR YOU WILL DEPLOY TO YOUR PERSONAL VERCEL NAMESPACE
# scope: ${{ secrets.VERCEL_TEAM_ID }}
# scope: ${{ secrets.VERCEL_ORG_ID }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for background, how will users know to uncomment this? Is it in the tutorial?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could definitely use some more documentation. I think the correct answer here is to prompt for this value when creating the project. I'll add a followup issue for that.

<% } else if (host.name === 'heroku') { -%>
- uses: akhileshns/heroku-deploy@v3.4.6
with:
Expand Down
5 changes: 3 additions & 2 deletions packages/create-bison-app/template/package.json.ejs
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@
"build:next": "next build",
"build:nexus": "NODE_ENV=development ts-node -P tsconfig.cjs.json --transpile-only graphql/schema.ts",
"cypress:open": "cypress open",
"cypress:run": "cypress run",
"db:migrate": "yarn -s prisma migrate up --experimental && yarn build:prisma",
"db:rollback": "yarn prisma migrate down --experimental && yarn build:prisma",
"db:setup": "yarn db:migrate && yarn prisma generate",
Expand Down Expand Up @@ -73,7 +74,7 @@
"@graphql-codegen/typescript-react-apollo": "1.17.6",
"@graphql-codegen/typescript-resolvers": "1.17.4",
"@prisma/cli": "2.8.1",
"@testing-library/cypress": "^6.0.0",
"@testing-library/cypress": "^7.0.2",
"@testing-library/dom": "^7.21.7",
"@testing-library/jest-dom": "^5.11.2",
"@testing-library/react": "^10.4.7",
Expand All @@ -86,7 +87,7 @@
"@vercel/node": "^1.7.3",
"chance": "^1.1.6",
"concurrently": "^5.2.0",
"cypress": "^5.0.0",
"cypress": "^6.1.0",
"eslint": "^7.5.0",
"eslint-plugin-cypress": "^2.11.1",
"eslint-plugin-echobind": "^0.2.0",
Expand Down