ci: update GH Action & Cypress dependencies for a successful build. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also sets the default vercel scope to secrets.VERCEL_ORG_ID
Previously, we were accidently installing 2 versions of Cypress. See: cypress-io/cypress#4595
mcavaliere
reviewed
Dec 16, 2020
| @@ -125,14 +125,14 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| <% if (host.name === 'vercel') { -%> | |||
| - uses: ngduc/vercel-deploy-action@master | |||
| - uses: amondnet/vercel-action@v20 | |||
mcavaliere
reviewed
Dec 16, 2020
| with: | ||
| vercel-token: ${{ secrets.VERCEL_TOKEN }} | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| vercel-org-id: ${{ secrets.VERCEL_ORG_ID}} | ||
| vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID}} | ||
| # SET THIS OR YOU WILL DEPLOY TO YOUR PERSONAL VERCEL NAMESPACE | ||
| # scope: ${{ secrets.VERCEL_TEAM_ID }} | ||
| # scope: ${{ secrets.VERCEL_ORG_ID }} |
There was a problem hiding this comment.
Just for background, how will users know to uncomment this? Is it in the tutorial?
There was a problem hiding this comment.
It could definitely use some more documentation. I think the correct answer here is to prompt for this value when creating the project. I'll add a followup issue for that.
code-jenn-or
pushed a commit
that referenced
this pull request
Mar 24, 2021
…117) * update actions/setup-node to 2.1.2 * update vercel-action to amondnet/vercel-action@v20. This also sets the default vercel scope to secrets.VERCEL_ORG_ID * fixes Cypress issues Previously, we were accidently installing 2 versions of Cypress. See: cypress-io/cypress#4595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three major changes required here. The
setup-nodestep was done by @cmejet in #112. I split it out to a separate PR so that we can keep the Chakra UI upgrade isolated.This PR also replaces the forked version of
vercel-actionthat we were using previously(https://github.com/ngduc/vercel-deploy-action) with the original one (https://github.com/amondnet/vercel-action). It has the required updates for the recentset-envdeprecation from GitHub (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/).Finally,
@testing-library/cypresscombined with our main Cypress version was causing us to download it twice, then fail the build on a checksum error. For more background, see: cypress-io/cypress#4595Changes
setup-nodeto v2.1.2vercel-actionto v20@testing-library/cypressto^7.0.2cypressto^6.1.0Screenshots
Checklist
Fixes #116