Pixel improvements #4559
Merged
Pixel improvements #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
27 tasks
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
c0dec17
to
41fa4b1
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
2 times, most recently
from
2d07063
to
2447b8c
Compare
13 tasks
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
41fa4b1
to
9781350
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
from
2447b8c
to
6732515
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
9781350
to
0931b1e
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
from
6732515
to
a188a19
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
0931b1e
to
6882c51
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
from
a188a19
to
6420876
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
6882c51
to
57e6207
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
from
6420876
to
9dc841a
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/in-app-message
branch
from
57e6207
to
ff9d2d0
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/pixels
branch
from
9dc841a
to
ba1b62c
Compare
Task/Issue URL: https://app.asana.com/0/0/1207259212212441/f ### Steps to test this PR _Feature 1_ - [ ] Write a random query like "asdasdhauhqwufdrgqfiu" - [ ] Check there's only one result displayed and that it contains the same query - [ ] Check the autocomplete list takes all available vertical space so the site underneath is not visible ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
CrisBarreiro
merged commit afb46ea
into
feature/cbarreiro/autocomplete/in-app-message
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207259212212442/f
Description
Add new pixels and update existing ones
Steps to test this PR
Feature 1
UI changes