Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in app message for autocomplete #4545

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented May 14, 2024

Task/Issue URL: https://app.asana.com/0/0/1206816228247403/f

Description

Display an in-app message (above auto-complete results. See https://app.asana.com/0/0/1206816228247403/f for rules

Steps to test this PR

Update RC and set storeHistory to enabled. Alternatively, update shouldStoreHistory in RealHistoryWrapper so it returns true

Banner is not shown for new users

  • Do a clean install
  • Perform a search or visit a site
  • Repeat the same query again
  • Check history-based results are shown but no in-app message appears
  • Complete the onboarding
  • Repeat the same query again
  • Check history-based results are shown but no in-app message appears

Banner is shown for existing users

  • Update from a previous version of the app with completed onboarding, or update isExistingUser in AutoCompleteso it returns true and do a clean install
  • Perform a search or visit a site
  • Repeat the same query again
  • Check history-based results are shown but and an in-app message appears

Banner isn't shown after being dismissed

  • Update isExistingUser in AutoCompleteso it returns true and do a clean install
  • Perform a search or visit a site
  • Repeat the same query again
  • Check history-based results are shown but and an in-app message appears
  • Close the banner
  • Repeat the same query again
  • Check history-based results are shown but no in-app message appears

Banner is not shown when there are no history based-results results

  • Update isExistingUser in AutoCompleteso it returns true and do a clean install
  • Visit wikipedia.org and add it to favorites
  • Use fire button
  • Type wikipedia
  • Check no history-based results nor the banner are shown

Banner isn't shown more than 3 times
Update isExistingUser in AutoCompleteso it returns true and do a clean install

  • Perform a search or visit a site
  • Repeat the same query again
  • Check history-based results are shown but and an in-app message appears
  • Repeat previous 3 steps 4 times. Check the fourth time, the banner isn't shown anymore

UI changes

banner

@CrisBarreiro CrisBarreiro mentioned this pull request May 14, 2024
16 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch 2 times, most recently from d5cdd39 to d57e9e4 Compare May 14, 2024 11:49
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch 2 times, most recently from 0f2046a to 5d17569 Compare May 15, 2024 15:52
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from d57e9e4 to 2a9fdc6 Compare May 15, 2024 15:52
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from 5d17569 to 997ab03 Compare May 16, 2024 10:16
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch 2 times, most recently from 35faf79 to c0dec17 Compare May 20, 2024 07:53
@CrisBarreiro CrisBarreiro mentioned this pull request May 20, 2024
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from c0dec17 to 41fa4b1 Compare May 20, 2024 15:13
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from 997ab03 to 2b54b39 Compare May 22, 2024 08:46
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from 41fa4b1 to 9781350 Compare May 22, 2024 08:46
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from 2b54b39 to 1e05eca Compare May 22, 2024 09:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from 9781350 to 0931b1e Compare May 22, 2024 09:12
@CrisBarreiro CrisBarreiro mentioned this pull request May 22, 2024
3 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from 1e05eca to f63eb01 Compare May 22, 2024 14:22
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from 0931b1e to 6882c51 Compare May 22, 2024 14:22
@CrisBarreiro CrisBarreiro marked this pull request as ready for review May 22, 2024 14:27
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from f63eb01 to c0349ac Compare May 27, 2024 08:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from 6882c51 to 57e6207 Compare May 27, 2024 08:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/rc-flag branch from c0349ac to 0490131 Compare May 27, 2024 10:00
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/in-app-message branch from 57e6207 to ff9d2d0 Compare May 27, 2024 10:00
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


val suggestions = (topHits + filteredSearchResults + filteredBookmarks).distinctBy { it.phrase }

runBlocking {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to indicate a dispatcher here when changing to another thread, otherwise will be default.

Task/Issue URL: https://app.asana.com/0/0/1207259212212442/f 

### Description
Add new pixels and update existing ones

### Steps to test this PR

_Feature 1_
- [ ]
- [ ]

### UI changes
| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|
@CrisBarreiro CrisBarreiro merged commit 12b1933 into feature/cbarreiro/autocomplete/rc-flag May 29, 2024
4 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/autocomplete/in-app-message branch May 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants