-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in app message for autocomplete #4545
Add in app message for autocomplete #4545
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
d5cdd39
to
d57e9e4
Compare
0f2046a
to
5d17569
Compare
d57e9e4
to
2a9fdc6
Compare
5d17569
to
997ab03
Compare
35faf79
to
c0dec17
Compare
c0dec17
to
41fa4b1
Compare
997ab03
to
2b54b39
Compare
41fa4b1
to
9781350
Compare
2b54b39
to
1e05eca
Compare
9781350
to
0931b1e
Compare
1e05eca
to
f63eb01
Compare
0931b1e
to
6882c51
Compare
f63eb01
to
c0349ac
Compare
6882c51
to
57e6207
Compare
c0349ac
to
0490131
Compare
57e6207
to
ff9d2d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
val suggestions = (topHits + filteredSearchResults + filteredBookmarks).distinctBy { it.phrase } | ||
|
||
runBlocking { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to indicate a dispatcher here when changing to another thread, otherwise will be default.
Task/Issue URL: https://app.asana.com/0/0/1207259212212442/f ### Description Add new pixels and update existing ones ### Steps to test this PR _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
12b1933
into
feature/cbarreiro/autocomplete/rc-flag
Task/Issue URL: https://app.asana.com/0/0/1206816228247403/f
Description
Display an in-app message (above auto-complete results. See https://app.asana.com/0/0/1206816228247403/f for rules
Steps to test this PR
Update RC and set
storeHistory
to enabled. Alternatively, updateshouldStoreHistory
inRealHistoryWrapper
so it returns trueBanner is not shown for new users
Banner is shown for existing users
isExistingUser
inAutoComplete
so it returns true and do a clean installBanner isn't shown after being dismissed
isExistingUser
inAutoComplete
so it returns true and do a clean installBanner is not shown when there are no history based-results results
isExistingUser
inAutoComplete
so it returns true and do a clean installBanner isn't shown more than 3 times
Update
isExistingUser
inAutoComplete
so it returns true and do a clean installUI changes