Dependency cleanup #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release made the `Color` type `impl Copy` which is used in this crate.
This fixes `-Z minimal-versions` builds because this version of `toml` requires sufficient versions of its dependencies.
dtolnay
reviewed
Oct 28, 2019
There was a problem hiding this comment.
Thanks! Would it be possible to continue using the serde derive macros through the serde::{Deserialize, Serialize} reexport? That is the approach recommended in https://serde.rs/derive.html.
|
No, because |
|
Oh, it would be. However, this would leave |
mathstuf
force-pushed
the
dependency-cleanup
branch
from
8b3baf1
to
57c9bd4
Compare
|
I maintain Serde as well so it feels like we should fix it there. Fixing this this way in this crate doesn't seem like the right fix. Could you send a PR to serde instead? |
The documentation for `serde`'s `derive` feature states that it should really only be used for libraries with an optional `serde` feature themselves. That's not happening here. However, the need to split it is also required by `-Z minimal-versions` builds. Without a direct dependency, `serde_derive` 1.0.0 gets chosen. This is not suitable for this crate because it uses the `alias` feature. 1.0.103 is selected because it is the version that is compatible with `-Z minimal-versions`.
mathstuf
force-pushed
the
dependency-cleanup
branch
from
57c9bd4
to
dc70721
Compare
|
Now depends on a release of serde-rs/serde#1664 |
|
Published in 1.0.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it worth trying to find the actual minimum version of
serdefortoml-rs? See toml-rs/toml-rs@381d020 for details on that change.