Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal versions compat #1656

Closed
wants to merge 2 commits into from

Conversation

mathstuf
Copy link
Contributor

Bump minimum versions so that -Z minimum-versions compilation (mostly) works. Once dtolnay/trybuild#37 has a release, the build-tests crate can use that as a minimum. This patchset was made with removing build-tests from the workspace so that compilation succeeded in the meantime.

I also removed unused dependencies in the meantime (flate2 was particularly useful since it was using tokio-0.1 anyways).

Motivation

-Z minimum-versions is becoming more of a thing and tokio should work with it since it is so prevalent.

Solution

Find oldest versions of crates that failed to work with the flag and set that as the minimum version.

@carllerche
Copy link
Member

Thanks! Should this be added to CI? Or should we wait until trybuild has a release?

@mathstuf
Copy link
Contributor Author

I'd suggest adding a CI run for it once it works. I suppose adding a can-fail variant is fine for now.

Here is a Cirrus chunk for one of my crates. Note that it's not exactly the best since it should probably be testing against the minimum toolchain version as well. In another crate where GitLab-CI is being used, I have separate fetch and build jobs to allow for using nightly to make the lock file and the minimum version to test. I haven't looked into Cirrus enough to know how to structure jobs so that happens yet.

@carllerche
Copy link
Member

Unfortunately, there are conflicts now :( could you merge master and then I can merge this PR. 👍

This is the lowest version that excludes gcc 0.1.0 which has compilation
errors on today's toolchains.
@mathstuf
Copy link
Contributor Author

Rebased since master removed the tracing dependency which was bumped here.

@mathstuf
Copy link
Contributor Author

Seems that most of this has been made obsolete by other changes on master.

@mathstuf mathstuf closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants