Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum versions so that
-Z minimum-versions
compilation (mostly) works. Once dtolnay/trybuild#37 has a release, thebuild-tests
crate can use that as a minimum. This patchset was made with removingbuild-tests
from the workspace so that compilation succeeded in the meantime.I also removed unused dependencies in the meantime (
flate2
was particularly useful since it was using tokio-0.1 anyways).Motivation
-Z minimum-versions
is becoming more of a thing andtokio
should work with it since it is so prevalent.Solution
Find oldest versions of crates that failed to work with the flag and set that as the minimum version.