Add local + ci for source-build build infra #416
Add local + ci for source-build build infra #416
Conversation
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/xdt#352 for a similar PR, that this is based on.
From 61101604c89260e680df2d0e52c2dce84629ba00 Mon Sep 17 00:00:00 2001 | ||
From: Tom Deseyn <tom.deseyn@gmail.com> | ||
Date: Thu, 19 Nov 2020 20:06:23 +0100 | ||
Subject: [PATCH] xliff-tasks: remove netcoreapp2.1 targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch originally bumped from netcoreapp2.0
to net5.0
. I modified it change from netcoreapp2.1
to net5.0
. I am not sure if this make sense for master
, which really means net6.0
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master
is still on a 5.0.100
SDK, so I don't think we can use net6.0
yet. I think this is fine--we'll revisit in stage 4 (prebuilt removal) when presumably the repo will be on a newer SDK.
@MattGal PTAL |
@@ -0,0 +1,5 @@ | |||
<UsageData> | |||
<IgnorePatterns> | |||
<UsagePattern IdentityGlob="*/*" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not **/*? (recursive dirs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the docs here:
This defines which prebuilt NuGet packages are allowed to be used during the build. Initially, all package IDs and versions are permitted (
*/*
).The
*/*
glob means "any nupkg id, any version". It will be replaced with more specific rules at a later phase of the implementation plan.
It seems to mean a name/version
pair rather than a file glob.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this matches the common NuGet identity representation Microsoft.NETCore.App.Runtime/5.0.0
. (Typical nupkg filenames are ambiguous, using .
instead of /
.)
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source.
This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md
See dotnet/xdt#352 for a similar PR, that this is based on.