Skip to content
This repository has been archived by the owner on Oct 27, 2023. It is now read-only.

Add arcade-powered source-build basic configuration #367

Closed
wants to merge 1 commit into from

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 1, 2020

This adds the basic arcade-powered source-build configuration. I ran this with ./build.sh -c Release --restore --build --pack /p:ArcadeBuildFromSource=true.

No patches necessary. There was only one in dotnet/source-build, a legacy feed removal that already happened here. 馃憤


(Edit: adding some general text written later that might help put the PR in context a little better:)

This PR adds the local build infrastructure that lets ArPow (arcade-powered source-build) run in this repo. See https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/onboarding/local-onboarding.md for more details about how it works.

To try it out locally, run this on Linux: ./build.sh -c Release --restore --build --pack /p:ArcadeBuildFromSource=true -bl

This PR should have no effect on ordinary builds, or CI. ArPow stage 2 will add source-build to CI: PR validation and official builds.

For https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/implementation-plan.md

@dagood dagood requested a review from markwilkie October 1, 2020 19:31
@dagood dagood self-assigned this Oct 1, 2020
@dagood
Copy link
Member Author

dagood commented Oct 7, 2020

@alexperovich @ChadNedzlek will you be able to take a look at this soon? @markwilkie is listed as the owner of the repo (as far as arcade-powered source-build implementation goes) and added you to help review. Thanks.

Copy link
Member

@alexperovich alexperovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are valid msbuild/xml. After that I have no idea what they are supposed to do and if they actually do it. If it builds I guess its fine.

@ChadNedzlek
Copy link
Member

Same as Alex. I have no idea what tweaking those random MBBuild properties is going to do. :-)

@dagood
Copy link
Member Author

dagood commented Oct 7, 2020

I'm writing up some more impl-specific docs for the next implementation stage (adding source-build to CI) and I'm going to include some notes on these files. I've been assuming people looking at this would have context on arcade-powered source-build, so I sent this out before that's ready. But, there's no reason to rush on this particular PR.

In theory you could look at https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild to figure out what's going on, but the doc will be much more brief and specific to the files being touched here.

/cc @mmitche

@dagood
Copy link
Member Author

dagood commented Oct 8, 2020

I've added a doc about these changes to https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/onboarding/local-onboarding.md, can you take a look and see if this makes sense?

The next step of adding CI is also in there: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/onboarding. The current plan is to ask the source-build repo champ to do that. Looks like it should be the trivial case in this repo though, since it uses the Arcade jobs template. 馃檪

@dagood
Copy link
Member Author

dagood commented Feb 9, 2021

Closing in favor of #416. This PR is missing a patch that went into dotnet/source-build after I filed this PR initially.

@dagood dagood closed this Feb 9, 2021
@dagood dagood deleted the apsb branch February 9, 2021 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants