Add local + CI for source-build build infra #352
Conversation
|
Thanks @omajid! 😄 @vijayrkn, PTAL when you have a chance. This PR includes the arcade-powered source-build CI enable flag, so you might want to run a mock official build to validate it before merging to be sure it works internally: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/onboarding/ci-onboarding.md#end-result |
|
Thanks, @dagood for reminding me! |
|
Actually, nevermind. Both the patches here have been merged here already via #164 |
omajid
force-pushed
the
source-build-local-build-infra
branch
from
8832948
to
b9324da
Compare
omajid
changed the title
| @@ -4,6 +4,7 @@ | |||
| <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="6.0.0-beta.21101.7"> | |||
| <Uri>https://github.com/dotnet/arcade</Uri> | |||
| <Sha>2b430e5bbfaec37a6cead2f0cf79157f01f1a623</Sha> | |||
| <SourceBuild RepoName="arcade" ManagedOnly="true"/> | |||
There was a problem hiding this comment.
@dagood Is arcade available as a source-build dep? I just realized that https://github.com/dotnet/sourcelink/blob/master/eng/Version.Details.xml doesn't have this.
Should I delete this line from this PR?
There was a problem hiding this comment.
This line is should stay--the reason sourcelink can't depend on arcade is that arcade depends on sourcelink. There isn't always perfect logic in how we break the circular dependencies, this is just based on how we did it in .NET 5 and earlier, graphed out in the SVG at https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/implementation-plan.md
(If arcade wasn't available, I think the CI would fail to restore the Microsoft.SourceBuild.Intermediate.arcade package.)
There was a problem hiding this comment.
the reason sourcelink can't depend on arcade is that arcade depends on sourcelink
This is actually interesting, in theory source-built sourcelink can depend on source-built arcade, now that the work on arcade stage 3 is done. Maybe we should actually end up doing that to be even more sure that source-built versions of arcade will work in that repo. In any case, that's separate from this PR: filed dotnet/source-build#2022 to follow up.
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/xdt#352 for a similar PR, that this is based on.
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/xdt#352 for a similar PR, that this is based on.
omajid
force-pushed
the
source-build-local-build-infra
branch
from
b9324da
to
2586e10
Compare
|
Hey, @vijayrkn, can you please review this when you get a chance? |
|
@omajid, whenever it is convenient, can you pull in master and resolve the Version.Details.xml conflict? I would do it for you but I don't have access 😸 |
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
force-pushed
the
source-build-local-build-infra
branch
from
2586e10
to
4511f52
Compare
|
Thanks for reviewing and merging this! |
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source.
This is the first step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md
See dotnet/sourcelink#692 for a similar PR, that this is based on.
cc @dagood