Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source build #690

Closed
wants to merge 1 commit into from
Closed

Enable source build #690

wants to merge 1 commit into from

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 12, 2021

No description provided.

@dagood
Copy link
Member

dagood commented Jan 12, 2021

The container init problem is probably dotnet/source-build#1795. I think this can wait until we fix it on the dotnet/arcade side.

@dagood
Copy link
Member

dagood commented Jan 14, 2021

It looks like once this repo gets an Arcade SDK >= 6.0.0-beta.21064.7, this will work. (After changing from runSourceBuild -> enableSourceBuild and removing sourceBuildParameters.) It went green when I tried a manual upgrade at #692.

I also kicked off internal build on a dev branch to look ahead for build errors there.

@dagood
Copy link
Member

dagood commented Jan 14, 2021

I also kicked off internal build on a dev branch to look ahead for build errors there.

It hit issues in signing validation. 😕 It recursively looked at the nupkgs within the source-build intermediate nupkg and saw they're unsigned. At first glance it wouldn't make sense to me to actually sign these inner nupkgs. I'll look into this.

Base automatically changed from master to main March 17, 2021 22:33
@tmat
Copy link
Member Author

tmat commented Aug 12, 2021

@dagood Is this still relevant?

@dagood
Copy link
Member

dagood commented Aug 13, 2021

Thanks for checking--it can be closed. I included the commit in #692 which has already been merged.

@tmat tmat closed this Aug 13, 2021
@tmat tmat deleted the dev/tmat/sourcebuild branch October 28, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants