Enable source-build with Arcade SDK fixes #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tmat
approved these changes
Jan 15, 2021
|
@tmat Are you ok merging this PR with the not-quite-rolled-out Arcade SDK official build, or would you rather wait for the official rollout? I have a validation sourcelink official build running here to check these changes, FYI: https://dev.azure.com/dnceng/internal/_build/results?buildId=956759&view=results |
|
I don't mind either way. Up to you. |
|
Thanks, I think it's fine to go ahead. (I got mixed up and thought you had objected to merging without official auto-update in a previous PR, but I think it was a different repo.) Green PR and validation official build. Mind doing the honors? (I don't have permissions.) |
omajid
added a commit
to omajid/dotnet-xdt
that referenced
this pull request
Feb 3, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-xdt
that referenced
this pull request
Feb 3, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-symreader
that referenced
this pull request
Feb 9, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/test-templates
that referenced
this pull request
Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. Aside from arcade-specific changes, it also makes all `.sh` files executable to make this build under Linux/macOS. The rename from LICENSE to LICENSE.txt is a workaround for NuGet/Home#7601.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 11, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 12, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 12, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-linker
that referenced
this pull request
Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. The `LICENSE` to `LICENSE.txt` rename is hack to work around NuGet/Home#7601 for now.
omajid
added a commit
to omajid/dotnet-command-line-api
that referenced
this pull request
Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-symreader
that referenced
this pull request
Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-symreader
that referenced
this pull request
Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
tmat
pushed a commit
to dotnet/symreader
that referenced
this pull request
Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-xdt
that referenced
this pull request
Feb 24, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-xdt
that referenced
this pull request
Mar 3, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
added a commit
to omajid/dotnet-command-line-api
that referenced
this pull request
Mar 8, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. And try and resolve some nullability errors. For source-build, sisable warnings so we can build this without extensive customizations, since we update the TFM ourselves.
jonsequitur
pushed a commit
to dotnet/command-line-api
that referenced
this pull request
Mar 8, 2021
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on. And try and resolve some nullability errors. For source-build, sisable warnings so we can build this without extensive customizations, since we update the TFM ourselves.
dariuszkuc
pushed a commit
to apollographql/federation-hotchocolate
that referenced
this pull request
Oct 13, 2023
…11) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.SourceLink.GitHub](https://togithub.com/dotnet/sourcelink) | `1.1.0` -> `1.1.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/sourcelink (Microsoft.SourceLink.GitHub)</summary> ### [`v1.1.1`](https://togithub.com/dotnet/sourcelink/releases/tag/1.1.1) [Compare Source](https://togithub.com/dotnet/sourcelink/compare/1.1.0...1.1.1) #### Notable Changes - Feature: GitWeb Source Link provider by [@​Glen-Nicol-Garmin](https://togithub.com/Glen-Nicol-Garmin) in [dotnet/sourcelink#505 - Use submodule.name.url to determine the URL of a submodule by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#587 - Add Microsoft.SourceLink.Tools source package implementing SourceLinkMap by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#663 - Added support for gitea by [@​Mik4sa](https://togithub.com/Mik4sa) in [dotnet/sourcelink#674 - Enable source-build with Arcade SDK fixes by [@​dagood](https://togithub.com/dagood) in [dotnet/sourcelink#692 - Add netstandard2.0 target to tools package by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#702 - Update license to MIT by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#730 - Allow using .git directory instead of gitdir redirect in submodules. by [@​crummel](https://togithub.com/crummel) in [dotnet/sourcelink#653 - Fix discovery of working directory for worktrees by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#734 - Add support for the new GitLab raw url by [@​rgl](https://togithub.com/rgl) in [dotnet/sourcelink#713 - Target netcoreapp3.1 by [@​tmat](https://togithub.com/tmat) in [dotnet/sourcelink#767 #### New Contributors - [@​Glen-Nicol-Garmin](https://togithub.com/Glen-Nicol-Garmin) made their first contribution in [dotnet/sourcelink#505 - [@​IgorKustov-ChathamFinancial](https://togithub.com/IgorKustov-ChathamFinancial) made their first contribution in [dotnet/sourcelink#592 - [@​v-chmart](https://togithub.com/v-chmart) made their first contribution in [dotnet/sourcelink#604 - [@​0xced](https://togithub.com/0xced) made their first contribution in [dotnet/sourcelink#668 - [@​nycdotnet](https://togithub.com/nycdotnet) made their first contribution in [dotnet/sourcelink#672 - [@​Mik4sa](https://togithub.com/Mik4sa) made their first contribution in [dotnet/sourcelink#674 - [@​rgl](https://togithub.com/rgl) made their first contribution in [dotnet/sourcelink#713 - [@​adiaaida](https://togithub.com/adiaaida) made their first contribution in [dotnet/sourcelink#737 **Full Changelog**: dotnet/sourcelink@1.0.0...1.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/federation-hotchocolate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #690 with updated Arcade to get fixes/improvements.