Disable "MSBuild Server v1" by default #18526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
rainersigwald
approved these changes
Jun 24, 2021
src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
Outdated
Show resolved
Hide resolved
src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
Outdated
Show resolved
Hide resolved
…Logging.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com>
…Logging.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com>
| @@ -16,7 +16,7 @@ namespace Microsoft.DotNet.Cli.Utils | |||
| internal class MSBuildForwardingAppWithoutLogging | |||
| { | |||
| private static readonly bool AlwaysExecuteMSBuildOutOfProc = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_RUN_MSBUILD_OUTOFPROC"); | |||
| private static readonly bool DoNotUseMSBUILDNOINPROCNODE = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_DO_NOT_USE_MSBUILDNOINPROCNODE"); | |||
| private static readonly bool UseMSBUILDNOINPROCNODE = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_USE_MSBUILDNOINPROCNODE"); | |||
There was a problem hiding this comment.
I like this because later we can just change the default value to true.
rokonec
approved these changes
Jun 25, 2021
rainersigwald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabling the new MS Build server feature as it's not ready yet. Leaving the feature flag in place so we can continue to test it.
Prior change to enable this two weeks ago
#18263
Customer Impact
We've found multiple impacts from early dogfooding so far. The primary one below is that MSBuild can get into a state where it fails to expand wildcards, failing builds. Because of how confusing that was to track down and how unsure we are on other impact, we want to revert this to be safe.
dotnet/msbuild#6602
Another impact was we were blocked from updating stage 0 SDK in the installer repo so this could have a lot of other silent internal impact we haven't tracked down yet:
dotnet/installer#10940
Testing
Passed SDK tests.
Risk
Low, this flips a feature flag back off that was enabled only two weeks ago.