[release/6.0-preview6] Unpin Microsoft.Extensions.Logging

[bricelam]

Part of #25148

[ghost]

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

[ghost]

Apologies, while this PR appears ready to be merged, it looks like release/6.0-preview6 is a protected branch and I have not been granted permission to perform the merge.

[bricelam]

I've tried a few different things, but I keep getting this error:

C:\Projects\efcore\All.sln(2,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 2, position 1.

What I've tried:

• Updating the SDK to Preview 6
• Staying on the Preview 4 SDK and updating Microfot.NETCore.App to Preview 6

Staying on Preview 4 gives us the same error we pinned for in the first place:

System.MethodAccessException : Attempt by method 'System.Text.ValueStringBuilder.AppendSlow(System.String)' to access method 'System.String.CopyTo(System.Span`1`<Char>)' failed.

[dougbu]

Strange failures with the All.sln file and that hasn't changed since mid December. The newer SDK doesn't seem to like that file for some reason. Perhaps try the 6.0.100-preview.6.21313.2 SDK❔ That's where we're at in dotnet/aspnetcore but, then again, we don't use the solution file in CI builds.

[bricelam]

Any ideas @rainersigwald?

[bricelam]

try the 6.0.100-preview.6.21313.2 SDK

Weird. That seems to work 🤷‍♂️

[rainersigwald]

Thanks for reporting! This is a regression in preview6 builds that will be fixed by dotnet/sdk#18526. cc @rokonec for another test case after the dotnet/installer one.

You can work around the issue by setting the environment variable DOTNET_CLI_DO_NOT_USE_MSBUILDNOINPROCNODE=1, or (as you discovered) use a preview6 build from before the regression went into SDK (and the final preview6 build should also be fine).

[mmitche]

@bricelam Do you need p6? Could the shipping p5 work instead?

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

[bricelam]

Do you need p6?

We need the p6 runtime for the tests to pass.

I think I found a combination that'll work. 🤞

[mmitche]

Do you need p6?

We need the p6 runtime for the tests to pass.

I think I found a combination that'll work. 🤞

sounds good.

Usually most repos are using the following pattern to install the runtime that just flowed to the repo: https://github.com/dotnet/sdk/blob/main/global.json#L6

Then then flow that via this dependency: https://github.com/dotnet/sdk/blob/main/eng/Version.Details.xml#L33-L36

I think efcore doesn't strictly need to flow the runtime on every commit, just needs to have one such that the tests will pass. So if this pattern was used, we would remove it after RTM.

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

[bricelam]

Oops, hope I didn't step on your toes, @mmitche. Look like we both effectively just rebased...

[mmitche]

No problem. There's another flow from runtime I think, so it will align itself.