Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate errors when referencing an Executable project with different SelfContained value #15134

Merged
merged 5 commits into from Apr 22, 2021
Merged

Generate errors when referencing an Executable project with different SelfContained value #15134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1827e4
Add strings for self-contained exe reference mismatch
dsplaisted Dec 31, 2020
9167941
Don't use MSBuildAllProjects in Versions.props
dsplaisted Dec 31, 2020
48a8949
Add validation that executable references match SelfContained
dsplaisted Dec 31, 2020
74f522c
Use Xml for gathering additional properties from referenced projects
dsplaisted Jan 26, 2021
f8c33dc
Use separate folders for test
dsplaisted Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions eng/Versions.props
View file
Open in desktop
@@ -1,9 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
</PropertyGroup>
<!-- Opt out of certain Arcade features -->
<PropertyGroup>
<UsingToolNetFrameworkReferenceAssemblies>true</UsingToolNetFrameworkReferenceAssemblies>
Expand Down
8 changes: 8 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Expand Up @@ -698,4 +698,12 @@ The following are names of parameters or literal values and should not be transl
<value>NETSDK1148: A referenced assembly was compiled using a newer version of Microsoft.Windows.SDK.NET.dll. Please update to a newer .NET SDK in order to reference this assembly.</value>
<comment>{StrBegin="NETSDK1148: "}</comment>
</data>
<data name="SelfContainedExeCannotReferenceNonSelfContained" xml:space="preserve">
<value>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</value>
<comment>{StrBegin="NETSDK1150: "}</comment>
</data>
<data name="NonSelfContainedExeCannotReferenceSelfContained" xml:space="preserve">
<value>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</value>
<comment>{StrBegin="NETSDK1151: "}</comment>
</data>
</root>
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: Projekty C++/CLI cílené na rozhraní .NET Core nemůžou používat SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: Zabalit jako nástroj nepodporuje nezávislost.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: Balíček modulu runtime pro {0} se nestáhl. Zkuste spustit obnovení NuGet s identifikátorem RuntimeIdentifier {1}.</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: Cesty AdditionalProbingPaths byly zadány pro GenerateRuntimeConfigurationFiles, ale vynechávají se, protože RuntimeConfigDevPath je prázdné.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: C++-/CLI-Projekte für .NET Core können "SelfContained=true" nicht verwenden.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: Die Paketierung als Tool unterstützt keine eigenständige Bereitstellung.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: Das Laufzeitpaket für "{0}" wurde nicht heruntergeladen. Führen Sie eine NuGet-Wiederherstellung mit RuntimeIdentifier "{1}" aus.</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: Für GenerateRuntimeConfigurationFiles wurden "AdditionalProbingPaths" angegeben, sie werden jedoch übersprungen, weil "RuntimeConfigDevPath" leer ist.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: Los proyectos de C++/CLI destinados a .NET Core no pueden usar SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: El paquete como herramienta no admite la autocontención.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: no se descargó el paquete de tiempo de ejecución de {0}. Pruebe a ejecutar una restauración de NuGet con RuntimeIdentifier "{1}".</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: Se especificaron valores adicionales de "AdditionalProbingPaths" para GenerateRuntimeConfigurationFiles, pero se van a omitir porque el valor de "RuntimeConfigDevPath" está vacío.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: les projets C++/CLI qui ciblent le .NET Core ne peuvent pas utiliser SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: L'outil de compression ne prend pas en charge l'autonomie.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: le pack de runtime pour {0} n'a pas été téléchargé. Essayez d'exécuter une restauration NuGet avec le RuntimeIdentifier '{1}'.</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: Des 'AdditionalProbingPaths' ont été spécifiés pour GenerateRuntimeConfigurationFiles, mais ils sont ignorés, car 'RuntimeConfigDevPath' est vide.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: i progetti C++/CLI destinati a .NET Core non possono usare SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: la creazione di pacchetti come strumenti non prevede elementi autonomi.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: il pacchetto di runtime per {0} non è stato scaricato. Provare a eseguire un ripristino NuGet con RuntimeIdentifier '{1}'.</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: per GenerateRuntimeConfigurationFiles è stato specificato 'AdditionalProbingPaths', ma questo valore verrà ignorato perché 'RuntimeConfigDevPath' è vuoto.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: .NET Core をターゲットとする C++/CLI プロジェクトでは SelfContained=true を使用できません。</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: Pack As ツールは自己完結型をサポートしていません。</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: {0} のランタイム パックがダウンロードされませんでした。RuntimeIdentifier '{1}' で NuGet 復元を実行してみてください。</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: 'AdditionalProbingPaths' が GenerateRuntimeConfigurationFiles に指定されましたが、'RuntimeConfigDevPath' が空であるためスキップされます。</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Expand Up @@ -505,6 +505,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: .NET Core를 대상으로 하는 C++/CLI 프로젝트는 SelfContained=true를 사용할 수 없습니다.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</source>
<target state="new">NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable.</target>
<note>{StrBegin="NETSDK1151: "}</note>
</trans-unit>
<trans-unit id="PackAsToolCannotSupportSelfContained">
<source>NETSDK1053: Pack as tool does not support self contained.</source>
<target state="translated">NETSDK1053: 도구로서 팩은 자체 포함을 지원하지 않습니다.</target>
Expand Down Expand Up @@ -610,6 +615,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1112: {0}용 런타임 팩이 다운로드되지 않았습니다. RuntimeIdentifier '{1}'을(를) 사용하여 NuGet 복원을 실행해 보세요.</target>
<note>{StrBegin="NETSDK1112: "}</note>
</trans-unit>
<trans-unit id="SelfContainedExeCannotReferenceNonSelfContained">
<source>NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</source>
<target state="new">NETSDK1150: The referenced project '{0}' is a non self-contained executable. A non self-contained executable cannot be referenced by a self-contained executable.</target>
<note>{StrBegin="NETSDK1150: "}</note>
</trans-unit>
<trans-unit id="SkippingAdditionalProbingPaths">
<source>NETSDK1048: 'AdditionalProbingPaths' were specified for GenerateRuntimeConfigurationFiles, but are being skipped because 'RuntimeConfigDevPath' is empty.</source>
<target state="translated">NETSDK1048: GenerateRuntimeConfigurationFiles에 대해 'AdditionalProbingPaths'가 지정되었지만 'RuntimeConfigDevPath'가 비어 있어서 건너뜁니다.</target>
Expand Down