Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit CA1002 when type is sealed #6729

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't emit CA1002 when type is sealed #6729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2568f6f
Don't emit CA1002 when type is sealed.
CollinAlpert Jul 2, 2023
5f53de3
Fix tests.
CollinAlpert Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...yzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotExposeGenericLists.cs
View file
Open in desktop
Expand Up @@ -47,7 +47,8 @@ public override void Initialize(AnalysisContext context)
var field = (IFieldSymbol)context.Symbol;

// FxCop compat: only analyze externally visible symbols by default.
if (!context.Options.MatchesConfiguredVisibility(Rule, field, context.Compilation))
if (!context.Options.MatchesConfiguredVisibility(Rule, field, context.Compilation) ||
field.ContainingType is { TypeKind: TypeKind.Class, IsSealed: true })
{
return;
}
Expand All @@ -65,7 +66,8 @@ public override void Initialize(AnalysisContext context)
var property = (IPropertySymbol)context.Symbol;

if (property.IsOverride ||
property.IsImplementationOfAnyInterfaceMember())
property.IsImplementationOfAnyInterfaceMember() ||
property.ContainingType is { TypeKind: TypeKind.Class, IsSealed: true })
{
return;
}
Expand Down Expand Up @@ -95,7 +97,8 @@ public override void Initialize(AnalysisContext context)
}

if (methodSymbol.IsOverride ||
methodSymbol.IsImplementationOfAnyInterfaceMember())
methodSymbol.IsImplementationOfAnyInterfaceMember() ||
methodSymbol.ContainingType is { TypeKind: TypeKind.Class, IsSealed: true })
{
return;
}
Expand Down
19 changes: 19 additions & 0 deletions ...Tests/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotExposeGenericListsTests.cs
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@

using System.Threading.Tasks;
using Microsoft.CodeAnalysis.Testing;
using Test.Utilities;
using Xunit;
using VerifyCS = Test.Utilities.CSharpCodeFixVerifier<
Microsoft.CodeQuality.Analyzers.ApiDesignGuidelines.DoNotExposeGenericLists,
Expand Down Expand Up @@ -361,6 +362,24 @@ End Class
}.RunAsync();
}

[Theory, WorkItem(6626, "https://github.com/dotnet/roslyn-analyzers/issues/6626")]
[InlineData("public List<int> List { get; set; }")]
[InlineData("public List<string> _list;")]
[InlineData("public static List<byte> List;")]
[InlineData("public readonly List<float> _list;")]
[InlineData("public readonly List<int> _list;")]
[InlineData("public List<char> GetList() => throw null;")]
[InlineData("public void ConsumeList(List<double> list) {}")]
public Task SealedClass_NoDiagnostic(string code)
{
return VerifyCS.VerifyAnalyzerAsync(@$"
using System.Collections.Generic;

public sealed class Test {{
{code}
}}");
}

private static DiagnosticResult GetCSharpExpectedResult(int line, int col, string returnTypeName, string typeDotMemberName)
#pragma warning disable RS0030 // Do not use banned APIs
=> VerifyCS.Diagnostic()
Expand Down