Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit CA1002 when type is sealed #6729

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CollinAlpert
Copy link
Contributor

@CollinAlpert CollinAlpert requested a review from a team as a code owner July 2, 2023 13:14
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #6729 (5f53de3) into main (9653f96) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    dotnet/roslyn-analyzers#6729      +/-   ##
==========================================
- Coverage   96.33%   96.33%   -0.01%     
==========================================
  Files        1393     1393              
  Lines      325082   325093      +11     
  Branches    10711    10711              
==========================================
+ Hits       313160   313169       +9     
- Misses       9217     9218       +1     
- Partials     2705     2706       +1     

Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for triage on dotnet/runtime#88310 from the dotnet/runtime team.

@glen-84
Copy link

glen-84 commented Dec 8, 2023

@mavasani Triage done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for rule CA1002 on sealed classes
3 participants