Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name collision of analyzer class names and title resources #6346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public class DoNotAddArchiveItemPathToTheTargetFileSystemPath : SourceTriggeredTaintedDataAnalyzerBase
public class DoNotAddArchiveItemPathToTheTargetFileSystemPathAnalyzer : SourceTriggeredTaintedDataAnalyzerBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rename all the files to match the new type name?

{
internal const string RuleId = "CA5389";

Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA3061: <inheritdoc cref="DoNotAddSchemaByURL"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotAddSchemaByURL : DiagnosticAnalyzer
public sealed class DoNotAddSchemaByURLAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA3061";

Expand Down
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5360: <inheritdoc cref="DoNotCallDangerousMethodsInDeserialization"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotCallDangerousMethodsInDeserialization : DiagnosticAnalyzer
public sealed class DoNotCallDangerousMethodsInDeserializationAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5360";

Expand Down
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5359: <inheritdoc cref="DoNotDisableCertificateValidation"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotDisableCertificateValidation : DiagnosticAnalyzer
public sealed class DoNotDisableCertificateValidationAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5359";

Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5365: <inheritdoc cref="DoNotDisableHTTPHeaderChecking"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotDisableHTTPHeaderChecking : DiagnosticAnalyzer
public sealed class DoNotDisableHTTPHeaderCheckingAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5365";

Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5363: <inheritdoc cref="DoNotDisableRequestValidation"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotDisableRequestValidation : DiagnosticAnalyzer
public sealed class DoNotDisableRequestValidationAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5363";

Expand Down
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public class DoNotHardCodeCertificate : SourceTriggeredTaintedDataAnalyzerBase
public class DoNotHardCodeCertificateAnalyzer : SourceTriggeredTaintedDataAnalyzerBase
{
internal static readonly DiagnosticDescriptor Rule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5403",
Expand Down
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public class DoNotHardCodeEncryptionKey : SourceTriggeredTaintedDataAnalyzerBase
public class DoNotHardCodeEncryptionKeyAnalyzer : SourceTriggeredTaintedDataAnalyzerBase
{
internal static readonly DiagnosticDescriptor Rule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5390",
Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5375: <inheritdoc cref="DoNotUseAccountSAS"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseAccountSAS : DiagnosticAnalyzer
public sealed class DoNotUseAccountSASAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5375";

Expand Down
Expand Up @@ -17,7 +17,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5384: <inheritdoc cref="DoNotUseDSA"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseDSA : DiagnosticAnalyzer
public sealed class DoNotUseDSAAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5384";

Expand Down
Expand Up @@ -18,7 +18,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5386: <inheritdoc cref="HardCodedSecurityProtocolTitle"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseDeprecatedSecurityProtocols : DiagnosticAnalyzer
public sealed class DoNotUseDeprecatedSecurityProtocolsAnalyzer : DiagnosticAnalyzer
{
internal static readonly DiagnosticDescriptor DeprecatedRule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5364",
Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5394: <inheritdoc cref="DoNotUseInsecureRandomness"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseInsecureRandomness : DiagnosticAnalyzer
public sealed class DoNotUseInsecureRandomnessAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5394";

Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5373: <inheritdoc cref="DoNotUseObsoleteKDFAlgorithm"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseObsoleteKDFAlgorithm : DiagnosticAnalyzer
public sealed class DoNotUseObsoleteKDFAlgorithmAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5373";

Expand Down
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5379: <inheritdoc cref="DoNotUseWeakKDFAlgorithm"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseWeakKDFAlgorithm : DiagnosticAnalyzer
public sealed class DoNotUseWeakKDFAlgorithmAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5379";

Expand Down
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5374: <inheritdoc cref="DoNotUseXslTransform"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class DoNotUseXslTransform : DiagnosticAnalyzer
public sealed class DoNotUseXslTransformAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5374";

Expand Down
Expand Up @@ -22,7 +22,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5396: <inheritdoc cref="SetHttpOnlyForHttpCookie"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
internal class SetHttpOnlyForHttpCookie : DiagnosticAnalyzer
internal class SetHttpOnlyForHttpCookieAnalyzer : DiagnosticAnalyzer
{
internal static readonly DiagnosticDescriptor Rule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5396",
Expand Down
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5368: <inheritdoc cref="SetViewStateUserKey"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class SetViewStateUserKey : DiagnosticAnalyzer
public sealed class SetViewStateUserKeyAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5368";

Expand Down
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5395: <inheritdoc cref="MissHttpVerbAttribute"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseAutoValidateAntiforgeryToken : DiagnosticAnalyzer
public sealed class UseAutoValidateAntiforgeryTokenAnalyzer : DiagnosticAnalyzer
{
internal static readonly DiagnosticDescriptor UseAutoValidateAntiforgeryTokenRule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5391",
Expand Down
Expand Up @@ -20,7 +20,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5377: <inheritdoc cref="UseContainerLevelAccessPolicy"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseContainerLevelAccessPolicy : DiagnosticAnalyzer
public sealed class UseContainerLevelAccessPolicyAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5377";

Expand Down
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5393: <inheritdoc cref="DoNotUseUnsafeDllImportSearchPath"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseDefaultDllImportSearchPathsAttribute : DiagnosticAnalyzer
public sealed class UseDefaultDllImportSearchPathsAttributeAnalyzer : DiagnosticAnalyzer
{
internal static readonly DiagnosticDescriptor UseDefaultDllImportSearchPathsAttributeRule = SecurityHelpers.CreateDiagnosticDescriptor(
"CA5392",
Expand Down
Expand Up @@ -18,7 +18,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5385: <inheritdoc cref="UseRSAWithSufficientKeySize"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseRSAWithSufficientKeySize : DiagnosticAnalyzer
public sealed class UseRSAWithSufficientKeySizeAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5385";

Expand Down
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.NetCore.Analyzers.Security
/// CA5376: <inheritdoc cref="UseSharedAccessProtocolHttpsOnly"/>
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseSharedAccessProtocolHttpsOnly : DiagnosticAnalyzer
public sealed class UseSharedAccessProtocolHttpsOnlyAnalyzer : DiagnosticAnalyzer
{
internal const string DiagnosticId = "CA5376";

Expand Down
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseXmlReaderForDataSetReadXml : UseXmlReaderBase
public sealed class UseXmlReaderForDataSetReadXmlAnalyzer : UseXmlReaderBase
{
internal const string DiagnosticId = "CA5366";

Expand Down
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseXmlReaderForDeserialize : UseXmlReaderBase
public sealed class UseXmlReaderForDeserializeAnalyzer : UseXmlReaderBase
{
internal const string DiagnosticId = "CA5369";

Expand Down
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseXmlReaderForSchemaRead : UseXmlReaderBase
public sealed class UseXmlReaderForSchemaReadAnalyzer : UseXmlReaderBase
{
internal const string DiagnosticId = "CA5371";

Expand Down
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseXmlReaderForValidatingReader : UseXmlReaderBase
public sealed class UseXmlReaderForValidatingReaderAnalyzer : UseXmlReaderBase
{
internal const string DiagnosticId = "CA5370";

Expand Down
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.NetCore.Analyzers.Security
using static MicrosoftNetCoreAnalyzersResources;

[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
public sealed class UseXmlReaderForXPathDocument : UseXmlReaderBase
public sealed class UseXmlReaderForXPathDocumentAnalyzer : UseXmlReaderBase
{
internal const string DiagnosticId = "CA5372";

Expand Down