Avoid name collision of analyzer class names and title resources #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 1366 1366
Lines 315512 315512
Branches 10187 10187
=======================================
+ Hits 303145 303146 +1
+ Misses 9934 9933 -1
Partials 2433 2433 |
mavasani
reviewed
Dec 20, 2022
| @@ -10,7 +10,7 @@ namespace Microsoft.NetCore.Analyzers.Security | |||
| using static MicrosoftNetCoreAnalyzersResources; | |||
|
|
|||
| [DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)] | |||
| public class DoNotAddArchiveItemPathToTheTargetFileSystemPath : SourceTriggeredTaintedDataAnalyzerBase | |||
| public class DoNotAddArchiveItemPathToTheTargetFileSystemPathAnalyzer : SourceTriggeredTaintedDataAnalyzerBase | |||
There was a problem hiding this comment.
Do we need to rename all the files to match the new type name?
|
Actually, I feel a better fix here is to rename the resource strings to always end with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during the work for unused resources analyzer.
The following line (as an example):
roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Security/DoNotAddArchiveItemPathToTheTargetFileSystemPath.cs
Line 19 in ed54cef
binds to the class, instead of binding to the resource:
roslyn-analyzers/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Lines 1083 to 1085 in ed54cef
Causing an incorrect "unused resource" warning.
Having different names will avoid this warning and will let
nameof(...)bind properly to the resource.