Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance fix for AnalysisEntityMapAbstractDomain.Merge algorithm #3058

Merged
merged 6 commits into from Nov 22, 2019
Merged

Performance fix for AnalysisEntityMapAbstractDomain.Merge algorithm #3058

merged 6 commits into from Nov 22, 2019

Commits on Nov 21, 2019

  1. Performance fix for AnalysisEntityMapAbstractDomain.Merge algorithm 

    We now ensure that we only create new entries in the result map if the entity key is a valid tracked entity
    @mavasani
    mavasani committed Nov 21, 2019
    Copy the full SHA
    5f67d69 View commit details
    Browse the repository at this point in the history

  2. Further optimization to delay merging values until required

    @mavasani
    mavasani committed Nov 21, 2019
    Copy the full SHA
    3794cc9 View commit details
    Browse the repository at this point in the history

  3. Refactor TrackedEntitiesBuilder to not expose the underlying tracked … 

    …entities set
    @mavasani
    mavasani committed Nov 21, 2019
    Copy the full SHA
    efd756e View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Add more unit tests - couple of these pass prior to this fix and fail… 

    … with this fix. Working on addressing these failures in a follow-up commit.
    @mavasani
    mavasani committed Nov 22, 2019
    Copy the full SHA
    4e94ce4 View commit details
    Browse the repository at this point in the history

  2. Track the reachable PointsTo values during PointsToAnalysis to ensure… 

    … that new reachable entities from Merge algorithm are not skipped. This commit fixes the analysis for tests added in previous commit.
    @mavasani
    mavasani committed Nov 22, 2019
    Copy the full SHA
    3a02a74 View commit details
    Browse the repository at this point in the history

  3. Use update instead of Add invocation to handle existing keys

    @mavasani
    mavasani committed Nov 22, 2019
    Copy the full SHA
    e6b0441 View commit details
    Browse the repository at this point in the history