New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance fix for AnalysisEntityMapAbstractDomain.Merge algorithm #3058
Conversation
We now ensure that we only create new entries in the result map if the entity key is a valid tracked entity
src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/PointsToAnalysis/TrackedEntitiesBuilder.cs
Show resolved
Hide resolved
… with this fix. Working on addressing these failures in a follow-up commit.
… that new reachable entities from Merge algorithm are not skipped. This commit fixes the analysis for tests added in previous commit.
@dotpaul I was able to validate no performance regression in building Roslyn after this fix, let me know once your validations are done. Thanks! |
Other than the one case @LLLXXXCCC emailed about, the previous repros looks good to me! I'm trying a pass on a larger code base; will approve after that finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 Improved performance from what I can see.
Thank you @dotpaul! |
We now ensure that we only create new entries in the result map if the entity key is a valid tracked entity