Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the image handler to measure more accurately WRT aspect ratio #7389

Merged
merged 1 commit into from May 23, 2022
Merged

Allow the image handler to measure more accurately WRT aspect ratio #7389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Core/src/Handlers/Image/ImageHandler.Android.cs
View file
Open in desktop
Expand Up @@ -7,7 +7,18 @@ namespace Microsoft.Maui.Handlers
{
public partial class ImageHandler : ViewHandler<IImage, ImageView>
{
protected override ImageView CreatePlatformView() => new AppCompatImageView(Context);
protected override ImageView CreatePlatformView()
{
var imageView = new AppCompatImageView(Context);

// Enable view bounds adjustment on measure.
// This allows the ImageView's OnMeasure method to account for the image's intrinsic
// aspect ratio during measurement, which gives us more useful values during constrained
// measurement passes.
imageView.SetAdjustViewBounds(true);

return imageView;
}

protected override void DisconnectHandler(ImageView platformView)
{
Expand Down