Allow the image handler to measure more accurately WRT aspect ratio #7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue 2000 on Android
mattleibow
approved these changes
May 21, 2022
|
/azp run |
jsuarezruiz
approved these changes
May 23, 2022
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allows the Android ImageView measure call to account for the intrinsic aspect ratio of the image when measuring with constraints. Otherwise, the image measurement will always come back with the intrinsic size of the image, which is almost never what we want when downscaling an image to fit a space.
Issues Fixed
Fixes #2000 for Android; does not address iOS.