"Arduino C# Compiler" #1785
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| echo on | ||
|
There was a problem hiding this comment. Per my previous comment, let's just remove this file for now. We can later decide to add a separate pipeline that we can conditionally invoke in some PRs that where it is relevant. There was a problem hiding this comment. This is the build script, not the yml file. We might adapt or change this, but deleting won't help. |
||
|
|
||
| REM First argument is the path to the user home directory (typically C:\Users\VssAdministrator) | ||
| REM Second argument is either "Debug" or "Release" | ||
| if %1!==! goto :usage | ||
|
|
||
| choco install -y --no-progress arduino-cli | ||
| arduino-cli lib install "DHT sensor library" | ||
| arduino-cli lib install "Servo" | ||
|
|
||
| arduino-cli config init | ||
| arduino-cli config add board_manager.additional_urls https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_dev_index.json | ||
| arduino-cli core update-index | ||
|
|
||
| set ArduinoRootDir=%1\Documents\Arduino | ||
| set acspath=%~dp0\..\tools\ArduinoCsCompiler\Frontend\bin\%2\net6.0\acs.exe | ||
|
|
||
| git clone https://github.com/firmata/ConfigurableFirmata %ArduinoRootDir%\libraries\ConfigurableFirmata | ||
| git clone https://github.com/pgrawehr/ExtendedConfigurableFirmata %ArduinoRootDir%\ExtendedConfigurableFirmata | ||
| arduino-cli core install esp32:esp32 | ||
|
|
||
| dir %ArduinoRootDir% | ||
|
|
||
| %acspath% --help | ||
|
|
||
| rem Write runtime data to ExtendedConfigurableFirmata directory, before building | ||
| %acspath% prepare | ||
|
|
||
| rem bring msbuild into the path | ||
| call "c:\program files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" | ||
|
|
||
| pushd %ArduinoRootDir%\ExtendedConfigurableFirmata | ||
|
|
||
| dir | ||
| REM First build the code for the ESP32 (this just verifies that the code builds, it does no run-time checks at all) | ||
| arduino-cli compile --fqbn esp32:esp32:esp32:PSRAM=disabled,PartitionScheme=default,CPUFreq=240,FlashMode=qio,FlashFreq=80,FlashSize=4M,UploadSpeed=921600,DebugLevel=none ./ExtendedConfigurableFirmata.ino --warnings default | ||
| if errorlevel 1 goto error | ||
|
|
||
| REM then build the simulator code as Visual Studio C++ project | ||
| msbuild /p:Configuration=%2 ExtendedConfigurableFirmataSim\ExtendedConfigurableFirmataSim.vcxproj | ||
| if errorlevel 1 goto error | ||
|
|
||
| REM Start the simulator asynchronously | ||
| start ExtendedConfigurableFirmataSim\%2\ExtendedConfigurableFirmataSim.exe | ||
|
|
||
| popd | ||
| pushd %~dp0\..\tools\ArduinoCsCompiler\ | ||
|
|
||
| REM and finally run the Arduino tests, now including the ones skipped previously. Set verbosity to normal to see | ||
| REM information about all tests being executed (as this test run can take 30 mins or more) | ||
| dotnet test -c %2 --no-build --no-restore --filter feature=firmata -l "console;verbosity=normal" -maxcpucount:1 | ||
| if errorlevel 1 goto error | ||
|
|
||
| popd | ||
| taskkill /im ExtendedConfigurableFirmataSim.exe /f | ||
|
|
||
| Echo All done! | ||
| exit /b 0 | ||
|
|
||
| :error | ||
| echo Tests failed. Error code %errorlevel% | ||
| exit /b 1 | ||
| :usage | ||
|
|
||
| echo Usage: ArduinoCsCI.cmd [path-to-home-directory] [Configuration] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add this to the main build yet. We should either make a new pipeline for this that can be invoked manually for a PR (probably ideal) or have some sort of logic that detects for changes on the Arduino or compiler bindings and would only run this job if any changes are detected. This latter option is less ideal, mainly cause you can't really invoke it if you want to run it even when changes are not detected, and it is also less maintainable since could be prone to breaking if files get moved around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't see much of a problem the way it is now. This is easily identifyable as it is a separate build, and when it breaks on a PR it can quickly be checked whether the breakage is due to a bad change in the Arduino binding or whether it is due to some problem completely unrelated to the PR. This is much like we do with the hardware tests now. The number of PRs we have is not so big that this extra check cost really a lot of time right now.