Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete flaky test MultipleThreadsForceRefresh #55290

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Apr 22, 2024

I added it to do manual validation and kept it when it seemed to be stable. To make it properly stable, we'd have to add a special test hook to let us manipulate lock usage, which doesn't seem worthwhile for the marginal coverage the test provides.

Fixes #55227

I added it to do manual validation and kept it when it seemed to be stable.  To make it properly stable, we'd have to add a special test hook to let us manipulate lock usage, which doesn't seem worthwhile for the marginal coverage the test provides.

Fixes dotnet#55227
@amcasey
Copy link
Member Author

amcasey commented Apr 23, 2024

I claim deleting this data protection test didn't break a bunch of MVC tests

@amcasey
Copy link
Member Author

amcasey commented Apr 23, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dataprotection Includes: DataProtection pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProviderTests.MultipleThreadsForceRefresh
2 participants