Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProviderTests.MultipleThreadsForceRefresh #55228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MackinnonBuck
Copy link
Member

See #55227

@MackinnonBuck MackinnonBuck requested review from wtgodbe and a team as code owners April 19, 2024 20:57
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 19, 2024
Copy link
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #55231 doesn't work, I may just delete the test. If I do so, I can clean up this entry as well. Otherwise, this seems like an appropriate way to handle it (with the addition of a comment like the one I suggest below).

eng/test-configuration.json Outdated Show resolved Hide resolved
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
@amcasey
Copy link
Member

amcasey commented Apr 22, 2024

The test is still failing. We should either quarantine it or, if it's not breaking a lot of people, wait for #55231. I was going to run its CI a couple more times, but I can just merge it directly to unbreak people.

@halter73
Copy link
Member

but I can just merge it directly to unbreak people.

Considering it's a code complete day, I think we should do this. Apparently the retries aren't sufficient though since the PR checks are still failing due to the test it's retrying failing repeatedly. Can we quarantine?

@amcasey
Copy link
Member

amcasey commented Apr 22, 2024

My preference would be to delete the test and then abandon this PR.

Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants