New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProviderTests.MultipleThreadsForceRefresh
#55228
base: main
Are you sure you want to change the base?
Conversation
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If #55231 doesn't work, I may just delete the test. If I do so, I can clean up this entry as well. Otherwise, this seems like an appropriate way to handle it (with the addition of a comment like the one I suggest below).
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
The test is still failing. We should either quarantine it or, if it's not breaking a lot of people, wait for #55231. I was going to run its CI a couple more times, but I can just merge it directly to unbreak people. |
Considering it's a code complete day, I think we should do this. Apparently the retries aren't sufficient though since the PR checks are still failing due to the test it's retrying failing repeatedly. Can we quarantine? |
My preference would be to delete the test and then abandon this PR. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
See #55227